Giter Site home page Giter Site logo

Comments (8)

soofstad avatar soofstad commented on August 13, 2024 1

Issue resolved by 85744ec.

Version 1.9.1 is now available with this included.

from react-oauth2-pkce.

albertwangnz avatar albertwangnz commented on August 13, 2024 1

Tested and it works. Thanks!

from react-oauth2-pkce.

soofstad avatar soofstad commented on August 13, 2024

Hi,
Can you please post your configuration?
Also, are you sure the access token is a valid JWT? You can try it out at pages like jwt.ms
And, are you receiving an id_token in the token request? Usually you need some special config on the provider, and a special scope for this.

from react-oauth2-pkce.

albertwangnz avatar albertwangnz commented on August 13, 2024

Hi @soofstad , thank you for your reply.

I created a fork of the project https://github.com/albertwangnz/react-oauth2-pkce-issue49, and you can see my change in the example microsoft-auth-provider. I use AWS Cognito as the auth provider.

As you can see in the screenshot below, idTokenData is empty but idToken is not, and I can manually parse idToken to an object with the data.

Screenshot from 2022-12-20 08-32-29

from react-oauth2-pkce.

albertwangnz avatar albertwangnz commented on August 13, 2024

I just guess the issue might be missing of using if (idToken) setIdTokenData(decodeJWT(idToken)) in the file below.

src/AuthContext.tsx

Line 195.

from react-oauth2-pkce.

anthony-vito avatar anthony-vito commented on August 13, 2024

I think he's right. The idToken data is decoded and assign on line 105 of the AuthContext when a login happens...... but there is another effect() that decodes the access token that starts on line 163..... What is the purpose of that effect() ? An additional decode for both tokens might need to be placed in there.

They should both also obey the configuration "config.decodeToken" to decide on if token decoding happens at all.

from react-oauth2-pkce.

soofstad avatar soofstad commented on August 13, 2024

You are both absolutely right.
Seems I was a bit quick on the testing for the last version.

As it is now, we decode the idToken on a received token response, but not when loading the page when the idToken is already fetched.

Will get a fix for this ASAP.

from react-oauth2-pkce.

albertwangnz avatar albertwangnz commented on August 13, 2024

Really appreciate your so fast response :-)

from react-oauth2-pkce.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.