tower init test, actually stop when you have enough to reach 2nd place

[taltamir]

tower init test, actually stop when you have enough to reach 2nd place

[Saklad5]

I recently saw it maximize for the tower tests, then undo all of that when maximizing during pre-adventure operations. I haven’t replicated this without beta being enabled, so take that with a grain of salt.

[jaspercb]

I currently think that happens for the initiative test but not for others, and have a fix pending. If you see it happening on other tests, please let me know!

[jaspercb]

The fix is "remove the call to presool, why was that there in the first place?"

[Saklad5]

The fix is "remove the call to presool, why was that there in the first place?"

When was it added? What's the point of version control if we have to guess?

[jaspercb]

When was it added? What's the point of version control if we have to guess?

Looks like it was last touched in e8f9553, seven months ago - and that was one of the big "batch rename everything" commits. I think it's safe to remove.

[Saklad5]

Unfortunately, it looks like that change wasn't under version control, at least in the context of this repository. The call to precheese was in the initial commit.

I can only assume there was a reason for it at some point, even if there doesn't appear to be one now.

[Saklad5]

On a related note, I really wish ASH had a more sophisticated scope system. Everyone ends up using cli_execute instead of import due to unavoidable namespace collisions, or embedding all the functions in main to sidestep the same. Scripts would be much easier to read if you could make functions private.

Granted, most of the things I want in ASH boil down to "I wish I was using Swift".

[jaspercb]

I can only assume there was a reason for it at some point, even if there doesn't appear to be one now.

Original commit was in January 2016, at https://sourceforge.net/p/ccascend/code/637/

I think it's safe to remove now.