Comments (3)
My initial instinct on this is that we'd have to consider backwards compatibility for people who already have large logo's uploaded which fit nicely into 32px - as we don't want to stretch these and make them look too large.
Guess if we'd need to do something server side to fix all existing logo's at 32px.
from theme-whitelabel.
Reading some debates about resizing the original files and how it's a bad idea which can cause further issues down the line.
This would suggest we need to look at adding a 32px image style for the logo, along with a 50px version. but only reprocess old logos through the 32px. When asking for the logo URL from the brand class it'll give us the 50px version should it exist, otherwise the 32px.
I need to see if we can call reprocess! for certain styles only?
from theme-whitelabel.
More research in paperclip would suggest we're able to reprocess just a single given style rather than multiples. https://github.com/thoughtbot/paperclip/wiki/Thumbnail-Generation#generatingregenerating-your-thumbnails
I think this works as a solution - we need to move this conversation over to the core application issue list and resolve it that end before we can progress the theme changes.
from theme-whitelabel.
Related Issues (20)
- Use of target="_blank" is considered insecure HOT 1
- Add Portuguese (Brazilian) Translations HOT 1
- Display began_at/ended_at timestamps on notices HOT 2
- Add support for the new "drill" state HOT 2
- Stop using partials/includes for things which are not reusable.
- Switch from tabs to spaces
- Drop the "overview" heading on planned notices
- Move rendering of planned notice schedule out of the "update" partial. HOT 1
- Include "timeliness" on present notices.
- Restructure the "timeliness" section to include began, ended and duration, like publishing UI from app.
- Have "duration" update using moment.js rather than relying on a cache refresh. HOT 6
- Add Lithuanian language support HOT 1
- Began/Ended timstamps are missing the timezone HOT 1
- Add support for Microsoft Teams subscription
- Add Portuguese language support HOT 1
- Improve styling for rich content in notice updates HOT 2
- Add the Norwegian language HOT 3
- Fonts don't encode into Base64 very well (Cloudflare) HOT 5
- Fix German language content HOT 1
- Improve ordering of past notices HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from theme-whitelabel.