Giter Site home page Giter Site logo

Comments (3)

SirRawlins avatar SirRawlins commented on May 29, 2024

My initial instinct on this is that we'd have to consider backwards compatibility for people who already have large logo's uploaded which fit nicely into 32px - as we don't want to stretch these and make them look too large.

Guess if we'd need to do something server side to fix all existing logo's at 32px.

from theme-whitelabel.

SirRawlins avatar SirRawlins commented on May 29, 2024

Reading some debates about resizing the original files and how it's a bad idea which can cause further issues down the line.

thoughtbot/paperclip#969

This would suggest we need to look at adding a 32px image style for the logo, along with a 50px version. but only reprocess old logos through the 32px. When asking for the logo URL from the brand class it'll give us the 50px version should it exist, otherwise the 32px.

I need to see if we can call reprocess! for certain styles only?

from theme-whitelabel.

SirRawlins avatar SirRawlins commented on May 29, 2024

More research in paperclip would suggest we're able to reprocess just a single given style rather than multiples. https://github.com/thoughtbot/paperclip/wiki/Thumbnail-Generation#generatingregenerating-your-thumbnails

I think this works as a solution - we need to move this conversation over to the core application issue list and resolve it that end before we can progress the theme changes.

from theme-whitelabel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.