Giter Site home page Giter Site logo

Comments (13)

soumith avatar soumith commented on August 19, 2024

@apage2 that sounds strange, happy to investigate. have you tried this code: https://github.com/szagoruyko/cifar.torch and see the same behavior?

from cudnn.torch.

szagoruyko avatar szagoruyko commented on August 19, 2024

I know what's the issue, I forgot to add reset function, preparing a PR

from cudnn.torch.

fmassa avatar fmassa commented on August 19, 2024

There is already a PR for that #114

from cudnn.torch.

szagoruyko avatar szagoruyko commented on August 19, 2024

@fmassa it wont work, no check for weight, bias and no running mean and std reset.

from cudnn.torch.

fmassa avatar fmassa commented on August 19, 2024

There is no option to remove the weight and bias from cudnn.SpatialBatchNormalization, plus the running mean and std are already set to zeros and ones.

from cudnn.torch.

soumith avatar soumith commented on August 19, 2024

ugh guys we cant have this kind of regressions. can you add tests for a case where we catch this issue?

from cudnn.torch.

szagoruyko avatar szagoruyko commented on August 19, 2024

@fmassa ah right. reset function is not just for ctor, can be called elsewhere.

from cudnn.torch.

soumith avatar soumith commented on August 19, 2024

so should I merge #116?

from cudnn.torch.

fmassa avatar fmassa commented on August 19, 2024

I think #116 is fine.
BTW, this regression was introduced in the original BatchNorm 4.0 PR #101

from cudnn.torch.

soumith avatar soumith commented on August 19, 2024

ok there's #116 and there's #114
Sergey, merge whichever is correct, i'll update distro in 30 mins

from cudnn.torch.

szagoruyko avatar szagoruyko commented on August 19, 2024

@soumith let me add a test. we should it to nn too btw.

from cudnn.torch.

soumith avatar soumith commented on August 19, 2024

@apage2 updating your cudnn.torch package via the command: (luarocks install cudnn) should fix things. sorry about that.

from cudnn.torch.

apage224 avatar apage224 commented on August 19, 2024

Nice, that was fast. I reran and it is working as expected.

Thanks.

from cudnn.torch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.