client_addr not included in configuration file

[sous-chefs]

client_addr not included in configuration file

[dpetzel]

After looking at this with a fresh pair of eyes, the client_addr attribute works. The problem I had was I didn't have the UI enabled. Is it reasonable that someone might want to run the HTTP API without the UI, and thus client_addr shouldn't be tied to the UI?

[ericfode]

@dpetzel I believe #78 should fix this, would you mind validating?

[dpetzel]

I'm not actually sure that's going to help in my case. If I'm reading it correctly your PR would result me in having to redefine client_addr into the extra params? While I could certainly do that it feels unnecessarily redundant. I think the fix is to remove the conditional around adding client_addr:

if node['consul']['serve_ui']
  service_config['ui_dir'] = node['consul']['ui_dir']
  service_config['client_addr'] = node['consul']['client_addr']
end

becomes something more like

service_config['client_addr'] = node['consul']['client_addr']
if node['consul']['serve_ui']
  service_config['ui_dir'] = node['consul']['ui_dir']
end

[ericfode]

@dpetzel sorry about that I misunderstood your issue. :P

On Thu, Nov 6, 2014 at 3:43 PM, dpetzel [email protected] wrote:

I'm not actually sure that's going to help in my case. If I'm reading it
correctly your PR would result me in having to redefine client_addr into
the extra params? While I could certainly do that it feels unnecessarily
redundant. I think the fix is to remove the conditional around adding
client_addr:

if node['consul']['serve_ui']
service_config['ui_dir'] = node['consul']['ui_dir']
service_config['client_addr'] = node['consul']['client_addr']
end

becomes something more like

service_config['client_addr'] = node['consul']['client_addr']
if node['consul']['serve_ui']
service_config['ui_dir'] = node['consul']['ui_dir']
end

—
Reply to this email directly or view it on GitHub
#73 (comment)
.

[dontrebootme]

Running into this same issue. I vote for having the conditional for the ui removed from accepting client_addr or being reworked as well.

[johnbellone]

I am closing this out because of impeding #126 landing on master.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.