Giter Site home page Giter Site logo

Comments (3)

etimoshenko avatar etimoshenko commented on May 26, 2024

I fixed this issue by changes in resources/pear.rb
Line 233-236:

if grep_for_version(shell_out(new_resource.binary + search_args).stdout, new_resource.package_name)
      false
elsif grep_for_version(shell_out(node['php']['pecl'] + search_args).stdout, new_resource.package_name)
      true

Changed to:

if grep_for_version(shell_out(new_resource.binary + search_args).stdout, new_resource.package_name) || 
grep_for_version(shell_out(node['php']['pecl'] + search_args).stdout, new_resource.package_name)
       true

I don't sure that it's right way. Please let me know if you have a solution.

from php.

devsibwarra avatar devsibwarra commented on May 26, 2024

I hit this problem using PHP cookbook 6.1.1 and Chef Client 14.10.9

Resource definition

php_pear 'amqp' do
  version '1.9.4'
  preferred_state 'stable'
  binary 'pecl'
end

Patch for resources/pear.rb

        if grep_for_version(shell_out(new_resource.binary + search_args).stdout, new_resource.package_name)
-          false
+          if new_resource.binary.include? 'pecl'
+            true
+          else
+            false
+          end

The pecl? code used to only test pear packages in the first conditional test, but when the binary param was added, this conditional test was not updated to support cases where binary was not the default value. I'm happy to roll this change into a PR if desired

from php.

lock avatar lock commented on May 26, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.