Design Review

[spacemeshos]

Design Review

[Motzart]

Regarding:

• Title: Smart Wallet... -> Vault [vault_name]. Subtitle: A vault app.

For a vault page. Subtitle is still A smart wallet app. Should be 'A vault app`.

Fix

[Motzart]

Regarding this issue:

• Call-out right-most column: Most Recent Account \n data\n age\n - no need for time-stamp and needs a label as it is not clear what the data is without one.

2nd line should be date - e.g day_of_month/month/year and not time stamp. I meant date in the comment and not data.
Also, first line Most Recent Account needs to appear in the first line. So we have:

Most Recent Account
8/21/2020
16 Days Ago

fix

[avive]

I think that in the short-term the gas_provided smidge amount from the transaction should be displayed for simple coin transactions as this amount is always paid by the user. Longer term, this data should come from the tx receipt.

[avive]

This is marked as fixed but I still see 0 in tx page. For example: https://stage-explore.spacemesh.io/txs/0xe1dffd47c453d88bb5f8f9891cc3d77b98c7c75bfe56bbd9de6beb2de3e0fb19

• Fee is always displayed 0 - should be taken from the tx object - user provider fee in smidge units.

[avive]

I still see the UTC time in the epochs screen and not the data, per this item (marked as fixed):

• We need to clarify that the time in the call-out is time since genesis. Add label Genesis Time. Remove detailed time-stamp and only keep date and age. e.g. 3 lines of text should be: Genesis Time\n 8/21/2020\n 9 days ago.

[avive]

Typo in subtitle: Layers details -> Layer details per this issue:

• Blue title: Layer 1278. Subtitle white: Layer details.

[avive]

Regarding this issue:

• Call-out right-most column: Most Recent Account \n data\n age\n - no need for time-stamp and needs a label as it is not clear what the data is without one.

2nd line should be date - e.g day_of_month/month/year and not time stamp. I meant date in the comment and not data.
Also, first line Most Recent Account needs to appear in the first line. So we have:

Most Recent Account
8/21/2020
16 Days Ago

[avive]

Regarding:

• Not clear what is the timestamp that is displayed on the top-right call-out. It should be the time of the last transaction but it is not. see: http://stage-explore.spacemesh.io/address/0xa7A424f4A77Bfd4b72EC5a68214ac8f3Da849236/txs .
  Let's make it display like this:

Most Recent Transaction
8/22/2020
16 Days Ago

[avive]

Regarding:

• Reward Committed -> Rewards.

Label is currently Reward - please change to Rewards.

[avive]

Regarding:

• Title: Smart Wallet... -> Vault [vault_name]. Subtitle: A vault app.

For a vault page. Subtitle is still A smart wallet app. Should be 'A vault app`.

[avive]

@Primaveralina - making sure you saw the issues here in my comments....

[avive]

@Motzart - did you see my comments here on some of the fixes?

[Motzart]

Regarding:

• Reward Committed -> Rewards.

Label is currently Reward - please change to Rewards.

Fix

[Motzart]

I still see the UTC time in the epochs screen and not the data, per this item (marked as fixed):

• We need to clarify that the time in the call-out is time since genesis. Add label Genesis Time. Remove detailed time-stamp and only keep date and age. e.g. 3 lines of text should be: Genesis Time\n 8/21/2020\n 9 days ago.

Fix

[Motzart]

This is marked as fixed but I still see 0 in tx page. For example: https://stage-explore.spacemesh.io/txs/0xe1dffd47c453d88bb5f8f9891cc3d77b98c7c75bfe56bbd9de6beb2de3e0fb19

• Fee is always displayed 0 - should be taken from the tx object - user provider fee in smidge units.

We get fee from back, it is equal 0

[avive]

This is marked as fixed but I still see 0 in tx page. For example: https://stage-explore.spacemesh.io/txs/0xe1dffd47c453d88bb5f8f9891cc3d77b98c7c75bfe56bbd9de6beb2de3e0fb19

• Fee is always displayed 0 - should be taken from the tx object - user provider fee in smidge units.

We get fee from back, it is equal 0

@lrettig - is this an API bug or a misunderstanding between API and backends? Currently all transactions show 0 fee. How can we address this?

[avive]

I still see the UTC time in the epochs screen and not the data, per this item (marked as fixed):

• We need to clarify that the time in the call-out is time since genesis. Add label Genesis Time. Remove detailed time-stamp and only keep date and age. e.g. 3 lines of text should be: Genesis Time\n 8/21/2020\n 9 days ago.

Fix

In the 119 explorer - I still see UTC formatted time in epoch screen, layer screen, tx screen, rewards screen. All dates should be displayed in user's (browser) local time.

[lrettig]

This is marked as fixed but I still see 0 in tx page. For example: https://stage-explore.spacemesh.io/txs/0xe1dffd47c453d88bb5f8f9891cc3d77b98c7c75bfe56bbd9de6beb2de3e0fb19

• Fee is always displayed 0 - should be taken from the tx object - user provider fee in smidge units.

We get fee from back, it is equal 0

@lrettig - is this an API bug or a misunderstanding between API and backends? Currently all transactions show 0 fee. How can we address this?

Which endpoint is being used to read this? Tx returned by TransactionService/MeshService does not include a "fee" field because there is no "fee" data stored on mesh. On mesh, we store the gas offered by a tx, which includes max gas (gas_provided) and gas price (not currently implemented). See https://github.com/spacemeshos/api/blob/a2af5cc13c7c112d996848b85219499ba0cbc233/proto/spacemesh/v1/types.proto#L34.

To see gas actually used/fee paid, you'd have to look at the TransactionReceipt which IIRC is not currently implemented either: https://github.com/spacemeshos/api/blob/a2af5cc13c7c112d996848b85219499ba0cbc233/proto/spacemesh/v1/global_state_types.proto#L53 and see spacemeshos/go-spacemesh#2072

[Motzart]

I still see the UTC time in the epochs screen and not the data, per this item (marked as fixed):

• We need to clarify that the time in the call-out is time since genesis. Add label Genesis Time. Remove detailed time-stamp and only keep date and age. e.g. 3 lines of text should be: Genesis Time\n 8/21/2020\n 9 days ago.

Fix

In the 119 explorer - I still see UTC formatted time in epoch screen, layer screen, tx screen, rewards screen. All dates should be displayed in user's (browser) local time.

Sorry, maybe i misunderstood, but all time in app use localtime ( time from browser ), maybe problem in label 'UTC', i removed it

[Motzart]

This is marked as fixed but I still see 0 in tx page. For example: https://stage-explore.spacemesh.io/txs/0xe1dffd47c453d88bb5f8f9891cc3d77b98c7c75bfe56bbd9de6beb2de3e0fb19

• Fee is always displayed 0 - should be taken from the tx object - user provider fee in smidge units.

We get fee from back, it is equal 0

@lrettig - is this an API bug or a misunderstanding between API and backends? Currently all transactions show 0 fee. How can we address this?

Which endpoint is being used to read this? Tx returned by TransactionService/MeshService does not include a "fee" field because there is no "fee" data stored on mesh. On mesh, we store the gas offered by a tx, which includes max gas (gas_provided) and gas price (not currently implemented). See https://github.com/spacemeshos/api/blob/a2af5cc13c7c112d996848b85219499ba0cbc233/proto/spacemesh/v1/types.proto#L34.

To see gas actually used/fee paid, you'd have to look at the TransactionReceipt which IIRC is not currently implemented either: https://github.com/spacemeshos/api/blob/a2af5cc13c7c112d996848b85219499ba0cbc233/proto/spacemesh/v1/global_state_types.proto#L53 and see spacemeshos/go-spacemesh#2072

@avive @lrettig so, judging from @lrettig comments we will have to wait until the necessary params are being implemented. right?

[avive]

I'm going to move any issue I see is not fixed yet to a new issue and close this mega issue.