Error: remove_email_envelope() function

[K0dical]

Error: remove_email_envelope() function

[xeor]

This breaks a lot of things for us as well.. I can't even do

ipdb> p mailparser.parse_from_bytes(orig.as_bytes())
*** TypeError: cannot use a string pattern on a bytes-like object
ipdb> p type(orig)
<class 'email.message.Message'>

The problem does not happen in 3.6.1

[fedelemantuano]

Fixed.

[dfeinzeig]

ah, this was my fault, sorry. @fedelemantuano I can create a fix to handle the python 3 bytes case.

[fedelemantuano]

@dfeinzeig for now we don't need it. If someone will have a problem, we can do that.

[dfeinzeig]

@fedelemantuano , i need it :) the problem is that the python 2 email library silently fails to parse emails with an envelope. i included a link to the spot in the python stdlib where this happens. https://github.com/python/cpython/blob/2.7/Lib/email/feedparser.py#L226 i can add a python 3 check for matching the envelope and in that case use a bytes type for matching: mailparser/utils.py", line 526, in remove_email_envelope True if EMAIL_ENVELOPE_PATTERN.search(message) else False TypeError: cannot use a string pattern on a bytes-like object

[fedelemantuano]

Can you send me a complete email with this problem? I want to see what's happen with mail-parser.

[dfeinzeig]

@fedelemantuano , i'm picking this back up. i need to add envelope checking and removal back for my purposes. let me know if you have any particular concerns about how you'd like this implemented. i'm thinking i'll likely add in the proper python version checking that i was missing before.

[dfeinzeig]

@fedelemantuano , i'm thinking something like this

dfeinzeig@503f502

And this time I've tested it with both python 2 and 3 :), including the exact bytes example the original poster mentioned.

[fedelemantuano]

Did you run any test?

[fedelemantuano]

I need to have test mails for this case. For now I can't manage this issue.