Giter Site home page Giter Site logo

Comments (3)

frbayart avatar frbayart commented on May 24, 2024

Hi, @gwwatkin
can you open a PR to fix it?

Thx

from spark-notebook.

gwwatkin avatar gwwatkin commented on May 24, 2024

Hi @frbayart,

Don't think I can :/ . looks like this is a problem with upstream sbt git stamp: hmrc/sbt-git-stamp#15. I'm not enough of an expert to go ahead and set up a mirror.

So to keep moving I just disabled the git stamping feature in the manifest file, which seems to work fine

Patch:
diff --git a/build.sbt b/build.sbt
index a46b5f20..22d9b33a 100644
--- a/build.sbt
+++ b/build.sbt
@@ -27,8 +27,6 @@ enablePlugins(GitVersioning)
 
 enablePlugins(GitBranchPrompt)
 
-import uk.gov.hmrc.gitstamp.GitStampPlugin._
-
 import com.typesafe.sbt.SbtNativePackager.autoImport.NativePackagerHelper._
 
 dockerBaseImage := DockerProperties.baseImage
@@ -346,9 +344,6 @@ lazy val sparkNotebook = rootProject.enablePlugins(SbtWeb)
     git.useGitDescribe := true,
     git.baseVersion := SparkNotebookSimpleVersion
   )
-  .settings(
-    gitStampSettings: _*
-  )
   .settings(
     Extra.sparkNotebookSettings
   )
diff --git a/project/plugins.sbt b/project/plugins.sbt
index 3c8b5405..1c59e009 100644
--- a/project/plugins.sbt
+++ b/project/plugins.sbt
@@ -4,10 +4,6 @@ logLevel := Level.Warn
 // The Typesafe repository
 resolvers += "Typesafe repository" at "https://repo.typesafe.com/typesafe/releases/"
 
-// The Sbt-Git-Stamp repo
-resolvers += Resolver.url("hmrc-sbt-plugin-releases",
-  url("https://dl.bintray.com/hmrc/sbt-plugin-releases"))(Resolver.ivyStylePatterns)
-
 // Use the Play sbt plugin for Play projects
 addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.5.15")
 
@@ -23,8 +19,6 @@ addSbtPlugin("com.eed3si9n" % "sbt-buildinfo" % "0.3.2")
 
 addSbtPlugin("com.typesafe.sbt" % "sbt-git" % "0.8.5")
 
-addSbtPlugin("uk.gov.hmrc" % "sbt-git-stamp" % "5.2.0")
-
 /**
   * coursier
   *

from spark-notebook.

falconepl avatar falconepl commented on May 24, 2024

I have recently created a fork of hmrc/sbt-git-stamp plugin:
https://github.com/nescale/sbt-git-stamp

It's available on Maven Central. You can switch to it by adding the following to the project/plugins.sbt file:

addSbtPlugin("com.nescale" % "sbt-git-stamp" % "1.0.0")

And those two lines to the build.sbt file:

import com.nescale.gitstamp.GitStampPlugin._

Seq(gitStampSettings: _*)

Check out the README for more details. Version 1.0.0 of the fork is compatible with the last version (6.2.0) of this plugin

from spark-notebook.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.