Inconsistent error when running example with BirghtnessAugmentation

[kwcckw]

Inconsistent error when running example with BirghtnessAugmentation

[tbrettallen]

Merge request has been approved and merged into the dev branch. Change has been deployed to version 2.0.4 of augraphy on pypi.

[shaheryar1]

Hi @kwcckw . Thanks for highlighting this.
The BrightnessAugmentation adjusts the brightness using HSV space. It can be applied to any phase (ink, paper,post) using self.layer argument.
But the "ink" phase inputs the image as Grayscale image with 1 channel only. Hence, its not compatible with hsv = cv2.cvtColor(img.astype("uint8"),cv2.COLOR_BGR2HSV) . It should be first converted into BGR format.

 def __init__(self, layer, range=(0.8, 1.4), probability=0.5):
    super().__init__(probability=probability)
    self.range = range
    self.layer = layer

I have adjusted the code, and I will push it in my PR. @jboarman

[kwcckw]

Hi @kwcckw . Thanks for highlighting this.
The BrightnessAugmentation adjusts the brightness using HSV space. It can be applied to any phase (ink, paper,post) using self.layer argument.
But the "ink" phase inputs the image as Grayscale image with 1 channel only. Hence, its not compatible with hsv = cv2.cvtColor(img.astype("uint8"),cv2.COLOR_BGR2HSV) . It should be first converted into BGR format.

 def __init__(self, layer, range=(0.8, 1.4), probability=0.5):
    super().__init__(probability=probability)
    self.range = range
    self.layer = layer

I have adjusted the code, and I will push it in my PR. @jboarman

Thanks, and in this case, since 'ink' phase input is in grayscale, probably we can just adjust the code similarly?

Right now i can see it is applied in saturation and value channel of hsv image, so if the input is grayscale, why don't we just apply it directly to the grayscale values?

[shaheryar1]

Yes this can also be done , as for single channel images to increase brightness we can tweak the saturation channel only.

[kwcckw]

Yes this can also be done , as for single channel images to increase brightness we can tweak the saturation channel only.

Sorry but how can we get saturation channel in single channel image? Merge same single channel image to bgr ( 3 channels of grayscale) , convert them to hsv and adjust the saturation channel?

[shaheryar909]

Yes you are right @kwcckw . We have to convert grayscale into bgr to get the saturation channel and adjust it.

[kwcckw]

Yes you are right @kwcckw . We have to convert grayscale into bgr to get the saturation channel and adjust it.

Alright thanks for the clarification again.