Giter Site home page Giter Site logo

Comments (3)

jboarman avatar jboarman commented on May 30, 2024

I'd be fine with removing rotation entirely since imgaug and albumentations already offer that and they handle transforms of any associated masks, bounding boxes or keypoints. I assume we will have to adapt our code to support transforms of any such associated data, but we will need to do that at some point anyway.

from augraphy.

proofconstruction avatar proofconstruction commented on May 30, 2024

I agree that we should move rotation, out of the augmentation pipeline (this was my motivation for #20 ).

I'm in favor of further restricting the scope of our augmentations, where possible. When training models you'd have to restrict training data to reasonably-rotated images (+/- 15%?) anyway, so I don't see a need for us to apply arbitrary rotations by default.

Right now, if you wanted to rotate an image, you could use imgaug's Rotate class within a ForeignAugmentation wrapper from our utilities module. You should be able to do this in any layer of the pipeline.

Maybe a good compromise is to just change the default rotation behavior in the pipeline to not rotate, but still provide the option to do so by passing a rotation range like we already do. Then the feature is still available within our package, and someone who wanted to rotate their images wouldn't require additional dependencies on other augmentation libraries for this purpose.

from augraphy.

proofconstruction avatar proofconstruction commented on May 30, 2024

With this commit, rotation is now optional in the AugraphyPipeline.

from augraphy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.