Comments (2)
nklomp
commented on May 25, 2024
You are correct. The low-level SIOPv2/OID4VP library being used by the SSI-SDK is still version 11. In that version the nonce was bound to the ID-token if memory serves me correctly. It isn't used in creating the VP. The SIOP library has options to pass in domain (client_id) and challenge (nonce) values. These are however not mapped onto client_id and nonce for JWT VPs currently. The change to make that work should be trivial, but I am a bit reluctant to do that given we will be refactoring the lib next few sprints anyway.
As mentioned the next few weeks we will be refactoring the SIOPv2/OID4VP lib to support the latest spec. This will also include some changes to the SDK and wallet.
Question I guess is, do you need it "now" or could you wait 4-5 weeks until the latest updates land in the wallet?
from ssi-sdk.
linasi
commented on May 25, 2024
Thank you for the reply @nklomp. Yes, seems like id_token does have nonce included into the token payload.
Sounds good, I can wait for the update.
from ssi-sdk.
Related Issues (18)
- When verifing from the mobile wallet, when the https://dev.uniresolver.io/ is down, the verification fails with gateway timeout HOT 3
- Get ERR_PACKAGE_PATH_NOT_EXPORTED when using ssi-sdk.oid4vci-issuer-rest-api. HOT 2
- State of OID4VC "auth. code flow" support HOT 2
- Status List bitstring bit ordering HOT 3
- oid4vciIssueCredential() fails when verifying did:peer proof HOT 1
- Including dynamic token for endpoint protection HOT 4
- Remove console.log from packages HOT 1
- Enhancement Request: Configurable CredentialOfferState in createVciIssuerBuilder HOT 1
- feature: make getInstanceOpts from SIOPv2RP fetching from the DB HOT 3
- Readme list of available functions doesn't match to code
- [oid4vci-issuer-rest-api] Can Access Tokens be Retrieved in CredentialDataSupplier? HOT 2
- Support for Bitstring Status List v1.0 HOT 1
- Get Issued Credentials HOT 4
- Dynamic update of presentation definitions HOT 3
- Converts a presentation to a wrapped presentation fails for sd-jwt HOT 2
- JWT is created with incorrect alg when making Authentication Response JWT HOT 3
- Intermittent issue when verifying Authentication Request HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ssi-sdk.