Giter Site home page Giter Site logo

Add geometry field types about daybed HOT 6 CLOSED

leplatrem avatar leplatrem commented on July 19, 2024
Add geometry field types

from daybed.

Comments (6)

leplatrem avatar leplatrem commented on July 19, 2024

Remains to be done :

  • A point should not be a colander.Sequence but a PointNode
  • Make use for colander.Range validators for GPS coordinates
  • Add check on LinearRing for polygons (last coordinate must be equal to first one).
  • Add holes for polygons (list of _LinearRing_s : first is exterior, following are holes)

from daybed.

leplatrem avatar leplatrem commented on July 19, 2024

Done !

Would be glad if someone could review code and docstrings please !

from daybed.

almet avatar almet commented on July 19, 2024

commented there. I think a pull request would have been more appropriate, however.

from daybed.

almet avatar almet commented on July 19, 2024

Overall, I like it! We should probably put all that in a separate module (.geo ?) like you proposed.
Also add some functional tests for it.

from daybed.

leplatrem avatar leplatrem commented on July 19, 2024

Code review is not very convenient on Github indeed... But since I'm a "repo collab", a branch is appropriate isn't it ?

Regarding the separate module, shall I make schemas a package then ?

We can discuss here :

  • the meaning and naming of that gps parameter instead of there
  • the proper approach for unit testing deserializations. Actually I globally followed the way colander does it

from daybed.

almet avatar almet commented on July 19, 2024

you can push a branch like you did and then issue a pullk request from this branch to master. that allows us to comment the overall diff.

from daybed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.