Lada breaks Laravel Telescope

[genesiscz]

Lada breaks Laravel Telescope

[spiritix]

Which version of Laravel are you using?

[genesiscz]

Laravel "version": "v7.4.0",
Telescope "version": "v3.2.0",

[genesiscz]

Simply making the fifth parameter optional ( = null) seems to fix this issue for me. I am not sure if it doesn't break something, but since everything in Telescope works, I suppose it doesnt.

[spiritix]

Thanks for providing the fix. It seems working, I merged it and will publish a bug fix release in a few moments.

[genesiscz]

Actually this broken a lot. Can you revert the commit and try to fix it more thoroughly?

  {"message": "Call to a member function getKeyName() on null",
    "exception": "Error",
    "file": "\/data\/...\/vendor\/spiritix\/lada-cache\/src\/Spiritix\/LadaCache\/Reflector.php",
    "line": 175,
    "trace": [
            "file": "\/data\...\/vendor\/spiritix\/lada-cache\/src\/Spiritix\/LadaCache\/Tagger.php",
            "line": 87,
            "function": "getRows",
            "class": "Spiritix\\LadaCache\\Reflector",
            "type": "->"
        },

[genesiscz]

Probably relationships

$instanceZones = Zone::where([
           "instance_id" => $instance_id,
           ["left", "<", $points->minLng],
           ["right", ">", $points->maxLng],
           ["bottom", "<", $points->minLat],
           ["top", ">", $points->maxLat],
       ])->with("zonePoints", "carrierZones", "storeZones")->get();

[spiritix]

Reverted the fix. It's actually weird how a default value for a previously required parameter can break something. Needs further investigation.

[genesiscz]

I forgot to said that if I manually assign a new App\Model\User in the constructor (when having the fifth parameter to null), it starts to work.

[genesiscz]

@spiritix will you have some time to look at this in a near future or should I investigate more? I am not sure about the dependencies and process and I wouldn't like to break it again considering there are no tests to try it on

[spiritix]

Not in the next weeks, can't promise anything. I will reopen the issue, maybe somebody else wants to have a look at it. Otherwise, I'll try to have a look as soon as possible.

[spiritix]

Should be fixed with the latest release