Comments (1)
Wow, thanks for sharing all your hard work! A lot of great improvements have been made with react-notion-x
.
Moving forwards I'd love to leverage a lot of the stuff you built. I outlined some of my thoughts on how to implement those changes, while remaining true to the vision of providing a minimal content renderer for Notion in #37.
Those are the things I think make sense to look into:
- Leverage the
notion-types
¬ion-utils
packages. They are quite unopinionated, and mostly dictated by what Notion does. Makes sense to solve those problems on dedicated packages, like you did. 👍 - Look into
notion-client
fornotion-api-worker
(cc @tobiaslins). Same as above, makes sense to focus that work in one central point, and make it reusable for other projects. As you mentioned is a good idea to directly talk to the API when using Next.js. For projects that are not using Node or need client-side communication, I still think the worker still has it's place. Also the/table
functionality is not handled bynotion-client
- not sure if it should, since I like the idea of it being just the a bare Notion API client without a lot of custom logic. Maybe the need for the/table
endpoints will be redundant once they launch the official API. - Start looking into the new block types and merge them over again.
Lazy loading complex blocks is definitely a good idea. I would try to avoid depending on next/dynamic
, since this rules out applications in other environments like Gatsby or manual SSR. I will put the new custom component system to the test, maybe it can provide a way to bring your own™ lazy load system.
from react-notion.
Related Issues (20)
- Handling null properties values
- HTML IDs missing on Callout blocks for internal links
- Is it possible to style for dark mode?
- Uncaught TypeError: can't access property "caption", value.properties is undefined
- Unsupported type undefined
- Notion teamspace page images not rendering
- react-notion crashes when rendering untitled toggle block
- twitter embed HOT 1
- Grid layout is not working properly. HOT 1
- notion worker only fetching default view.
- Images are overflowing HOT 2
- How to create pretty URL slugs posts? HOT 1
- Toggle block is not showing the content when expanded HOT 3
- Are there plans to add a renderer for the official Notion API? HOT 7
- Checkboxes do not render HOT 6
- Return errors when importing unsupported content types HOT 7
- Dark mode issue HOT 5
- Allow styled links HOT 1
- Getting error Unsupported type undefined for heading & paragraph HOT 1
- How to modify href for in-page links?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-notion.