UPLOADED event fires off when the responseCode is 4xx

[nvahalik]

UPLOADED event fires off when the responseCode is 4xx

[zfir]

Hello @nvahalik,

On which platform are you having this problem?

Regards,
Zafir.

[nvahalik]

Android seems to be the only one exhibiting the issue.

…

On 4 May 2022, at 1:51, Sk Heerah Zafir wrote: Hello @nvahalik, On which platform are you receiving this problem? Regards, Zafir. -- Reply to this email directly or view it on GitHub: #225 (comment) You are receiving this because you were mentioned. Message ID: ***@***.***>

[ombr]

I think this is expected. You should check the status code on your side. You will only get a failure if the request did not went through.

[nvahalik]

@ombr This makes no sense, though. Any response >= 400 is an error. A 4xx is a client error and a 5xx is a server error.

This is a bug in the plugin.

[ombr]

@nvahalik I understand this is not intuitive. This library was created from this library and was following the same principle (at that time) gotev/android-upload-service#259 (you should check the issue).

You are more than welcome to submit a pull-request for this.

One thing to keep in mind is that we might want to save the response even if the status code is > 400 as we might want to use it to better understand the error.

Thanks.

Luc