query values excessively decoded?

[sporkmonger]

query values excessively decoded?

[sporkmonger]

The #query_values is meant to decode application/x-www-form-urlencoded query strings. It does some other stuff as well, and it could probably be argued that that is a mistake, but regardless, if you look at application/x-www-form-urlencoded, you'll see that the + character is supposed to be treated as a space in that context. It's one of the more misguided bits of behavior that have found their way into a spec, but it's in the spec and we have to live with it. The work-around is to %-encode the + character. #query_values will not replace the + character with a space if it was %-encoded first.

I've implemented based on the definition in HTML 4.01, however, I intend to rewrite in the next major version against the definition in HTML5 as it's far less ambiguous and it's what will be implemented in most major browsers going forward:
http://www.w3.org/TR/html5/association-of-controls-and-forms.html#application-x-www-form-urlencoded-encoding-algorithm

[smparkes]

Actually, the part I'm unclear on is that the + that's being decoded into a space is one that was already % escaped.

[sporkmonger]

Oooooh, my bad. Yes, this was recently resolved — could you check out master and verify that it's fixed for you there?

[smparkes]

Yup. Looks good. Thanks!