Could URI#validate be made public?

[sporkmonger]

Could URI#validate be made public?

[sporkmonger]

It's called every time you parse a URI. It'll raise an exception if the URI is invalid.

For example: Addressable::URI.parse('http://example.com:bogus/')

[jwarchol]

Not if you don't set a port

>> Addressable::URI.parse('not even close to valid')
=> #<Addressable::URI:0x829c96cc URI:not even close to valid>

I guess a better question is why is the hostname part of the validate method checking if port, user, etc are nil?

[sporkmonger]

That is, in fact, a valid URI, believe it or not. It just happens to be relative and it's not in normal form, but it is a URI.

[sporkmonger]

If you'd like to reject relative URIs, you can just do this:

if uri.relative?
  raise ArgumentError, 'URI must be absolute.'
end

Also, if you're accepting input from humans, please be sure to use Addressable::URI.heuristic_parse, not Addressable::URI.parse.

[jwarchol]

Thank you for the detailed responses. I'm not clear at all on how that's relative, so it's time for me to RTFM a bit more.

[sporkmonger]

>> uri = Addressable::URI.parse('not even close to valid').normalize
=> #<Addressable::URI:0x80ad6a44 URI:not%20even%20close%20to%20valid>
>> uri.path
=> "not%20even%20close%20to%20valid"
>> uri.relative?
=> true

If a URI doesn't have a scheme component, it's relative.

This allows, for example, web pages to place anchors like this:

<a href="not even close to valid.html">elsewhere</a>

In this case, this link would resolve to:

>> uri_of_current_document = 'http://example.com/document.html'
=> "http://example.com/document.html"
>> (Addressable::URI.parse(uri_of_current_document) +
?>   "not even close to valid.html").normalize
=> #<Addressable::URI:0x80ac60cc URI:http://example.com/not%20even%20close%20to%20valid.html>