URI#query_values= breaks on nested hash containing array(s).

[sporkmonger]

URI#query_values= breaks on nested hash containing array(s).

[sporkmonger]

Looks legit. I'm pretty swamped right now though, so if this needs a timely fix, it's going to require someone sending me a patch with tests.

[newtonapple]

Looking through the code a bit, I've discovered a few problems with the current algorithm. I'll file these as separate issues. I can take a stab at reworking this method when I get some free time in the next couple of days.

[mikebridge]

I see this has been closed but I'm still seeing this bug.... has anyone already looked at it?

[newtonapple]

Yeah, looks like the current version 2.2.6 was tagged at cfd786b, right before my patches. It's been a few months now. Maybe it's time for another version bump and finally fix this bug?

[mikebridge]

Hi Newton,

Are you saying your fork fixes this issue?

-Mike

[sporkmonger]

I'm planning to overhaul the query_values method at some point in the near-ish future. However, that overhaul is likely to obsolete this bug rather than fixing it. This will likely be a breaking change for more complex query strings. Instead of offering several notations for converting to a query string, there will only be one notation supported. I'm simplifying this code. It's way too complex right now, and most of it needs to be deleted.

[mikebridge]

Version 2.2.7 actually has fixed this for me. I had grabbed it from http://rubygems.org/gems/addressable thinking I had the current version.

Thanks!

[bmck]

BTW, this seems to be broken in v.2.3.2.

1.9.3p327 :001 > uri = Addressable::URI.new
=> #<Addressable::URI:0x8244041c URI:>
1.9.3p327 :002 > uri.query_values = { 'a' => {'b' => [ 'c'] } }
TypeError: Can't convert Hash into String.

But, as mikebridge noted, it did work in 2.2.7.

[sporkmonger]

@bmck, this is intentional breakage. That's why the version number is 2.3.x and not 2.2.x.