Comments (9)
Looks legit. I'm pretty swamped right now though, so if this needs a timely fix, it's going to require someone sending me a patch with tests.
from addressable.
Looking through the code a bit, I've discovered a few problems with the current algorithm. I'll file these as separate issues. I can take a stab at reworking this method when I get some free time in the next couple of days.
from addressable.
I see this has been closed but I'm still seeing this bug.... has anyone already looked at it?
from addressable.
Yeah, looks like the current version 2.2.6 was tagged at cfd786b, right before my patches. It's been a few months now. Maybe it's time for another version bump and finally fix this bug?
from addressable.
Hi Newton,
Are you saying your fork fixes this issue?
-Mike
from addressable.
I'm planning to overhaul the query_values
method at some point in the near-ish future. However, that overhaul is likely to obsolete this bug rather than fixing it. This will likely be a breaking change for more complex query strings. Instead of offering several notations for converting to a query string, there will only be one notation supported. I'm simplifying this code. It's way too complex right now, and most of it needs to be deleted.
from addressable.
Version 2.2.7 actually has fixed this for me. I had grabbed it from http://rubygems.org/gems/addressable thinking I had the current version.
Thanks!
from addressable.
BTW, this seems to be broken in v.2.3.2.
1.9.3p327 :001 > uri = Addressable::URI.new
=> #<Addressable::URI:0x8244041c URI:>
1.9.3p327 :002 > uri.query_values = { 'a' => {'b' => [ 'c'] } }
TypeError: Can't convert Hash into String.
But, as mikebridge noted, it did work in 2.2.7.
from addressable.
@bmck, this is intentional breakage. That's why the version number is 2.3.x and not 2.2.x.
from addressable.
Related Issues (20)
- Improve pure ruby IDNA implementation to match browsers behavior (IDNA2008 and UTS#46) HOT 3
- Equivalent of `URI.regexp(schemes)`? HOT 4
- Crypto mining
- undefined method `to_str' for :id:Symbol (NoMethodError) in 2.8.2 HOT 8
- Template expansion does not work with symbolized hashes in 2.8.1 HOT 1
- Update to 2.8.2 break test env HOT 1
- Any version after 2.8.1 causes errors in our test suite coming from addressable. HOT 8
- Drop support for Ruby 2.2 (and more?) HOT 3
- Disallow backtick in host HOT 1
- Normalize errors when trying to run a simple url normalize HOT 4
- Unsafe concurrent Hash access HOT 9
- k
- feed:http: crashes servers HOT 11
- Valid domain not parsing HOT 1
- Improve release flow HOT 7
- Addressable::URI.escape method does not escape & properly as path param HOT 1
- "CWE-798 - Hardcoded credentials" in Amazon Inspector from uri_spec.rb
- Allow Public Suffix 6
- Stop testing on `macos-11` HOT 2
- Downgrade the dependency for public_suffix HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from addressable.