Giter Site home page Giter Site logo

Comments (2)

sporkmonger avatar sporkmonger commented on July 21, 2024

Yeah, this definitely looks like a problem. Could you try to produce a more condensed test-case that duplicates the issue? Basically, I need the simplest URI that fails in this manner.

from addressable.

sporkmonger avatar sporkmonger commented on July 21, 2024

Wait, no... actually I didn't look at this closely enough. This is working very much as intended. You've probably just misunderstood what's actually happening here.

That function is equivalent to this:

Addressable::URI.parse("http://example.com/") + Addressable::URI.parse("//")

That second URI resolves to a network-path reference with a host and path of "". This essentially means that the joined URI resolves to "http://", which is not a valid URI. However, the other examples you gave resolve to valid URIs: "http://example.com/", "http://example.com/?a", and "http:///" respectively.

Closing this issue.

from addressable.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.