Analysis with 3.4.1 fails for modules with only testclasses

[spotbugs]

Analysis with 3.4.1 fails for modules with only testclasses

[h3xstream]

The configuration to scan test files is an open issue #18.

Change required

The change although quite simple would require some unit tests and more integration testing. The proper enhancement will be include in the next version.

Behavior to add:

• If no source file are found it should skip the project, their is already a warning regarding the missing classes file.
• And obviously the analyzer should configurable to scan the tests.

Workaround

For the moment, I would suggest you to create a empty Java class in src/main/java/.

[amandel]

Thanks for picking this up. And I'm sure you saw that this is a regression coming from 3.3.

As a different workaround you can also skip the module in SonarQube altogether using maven means by adding -pl !xxx-test (xxx-test being the module name) to your mvn sonar:sonar call. This helps if you can not modify the project under analysis but you will obviously get no results at all for the excluded module.

I'm not sure if it is feasible through the Sonarqube API. Generally I would prefer to get a (blocker) issue reported sth like "Could not execute Findbugs cause of generic issue...", rather than a completely broken analysis in case of such a fatal analyzer issue. Might be I should ask for this on the other side of the API.

[h3xstream]

Currently, I was doing logging with WARN marker for non-critical observation.
Such as having JSPs that are not precompiled or compiled classes that do not have java file associated.

You could grep for those specific messages on your CI build task.

[amandel]

IMHO it would be nice to see these as issues in SonarQube: "Java file was not analyzed by FindBugs because no corresponding class file was found." or "..source could not be parsed", "...encoding issues in the source file." ...

[h3xstream]

@amandel Good point. I could not found anything like it in the API. It would be a good feature request.

[h3xstream]

I reconsider this issue as a blocker for the 3.4 release.

You can find the latest package here (sonar-findbugs-3.4.3.jar) : https://github.com/SonarQubeCommunity/sonar-findbugs/releases/tag/3.4

It is a minor code change (2 ifs conditions added only) but it should save a couple of headaches for users.

[amandel]

Cool! I can confirm that 3.4.3 fixes the above issue.

[INFO] Sensor FindBugs Sensor
[WARNING] Findbugs needs sources to be compiled. Please build project before executing sonar or check the location of compiled classes to make it possible for Findbugs to analyse your project.
[INFO] Findbugs analysis skipped for this project.
[INFO] Sensor FindBugs Sensor (done) | time=19ms

Thanks!

[h3xstream]

@amandel Thanks for the quick feedback.