Gradle 4.8 compatibility

[spotbugs]

Gradle 4.8 compatibility

[KengoTODA]

@chali OK then I'll merge that first. Thanks for your notice!

[fcurts]

@KengoTODA internal api -> use at your own risk (no b/w compatibility guarantees)

[chali]

I'm hitting the same issue. Here are more details and example project https://github.com/chali/spotbugsFailExample I'm suggesting this #24

[KengoTODA]

Thanks for your contribution! I've reproduced the reported runtime error by bdb9d85, and confirmed that @chali's commit b7eba42 fixes it. I'll create another PR from reproduce-gradle-failure branch.

@chali @ben-manes I cannot find related release note about this new method. Do you know what's the responsibility of it? I want to confirm that we really don't need any operation in this implementation.

• https://github.com/gradle/gradle/releases/tag/v4.8.0-RC1

[ben-manes]

@big-guy could explain this. The Gradle commit is below. Maybe follow the FindBugs change?

gradle/gradle@d3bcd32

[KengoTODA]

@big-guy I'm afraid that your commit broke backward compatibility,

or is it better to stop depending on AbstractCodeQualityPlugin that is located in internal package?

[KengoTODA]

Got it, thanks! Then I believe that the best fix is to stop depending on AbstractCodeQualityPlugin, I will close #25.

[chali]

@KengoTODA do you think that it makes sense to do a fix like #25 to get the plugin working and then work on getting away from AbstractCodeQualityPlugin Gradle 4.8 release is planned at the of May. All users of spotbugs are blocked in migration to it.