Latest version (1.6.2) fails with Gradle 4.10 nightly snapshot

[spotbugs]

Latest version (1.6.2) fails with Gradle 4.10 nightly snapshot

[chali]

Thank you @KengoTODA for reopening. Gradle 4.10 was released today. I updated the example to use it and I can confirm that spotbugs-gradle-plugin 1.6.2 still fails with the latest Gradle release. Spotbugs users cannot use Gradle 4.10. Do you have any thoughts about my PR? Can we merge it and create version 1.6.3?

[baron1405]

@KengoTODA can you please release a new version of the plugin to unblock Gradle 4.10 upgrades. I completely understand that you may be occupied with other things. In that case, can you add another maintainer for the project? I believe that @chali would be willing to help out.

[KengoTODA]

1.6.3 has been released.

BTW our repository has RELEASE_PROCEDURE.md so everyone can propose a PR to release this plugin. Please have a try next. :)

[baron1405]

As an additional data point, I too am experiencing the same build failure using the Spotbugs plugin with the released version of Gradle 4.10.

[baron1405]

@KengoTODA thanks for merging the PR. Can we get a release?

[chali]

Yes! @KengoTODA I'm happy to help.

[baron1405]

@KengoTODA can we get a release with the fix from @chali. This issue is a blocker for upgrading Gradle in our enterprise. Thanks.

[baron1405]

Note that the above reference from the Gradle team is simply to point a user at this issue since they were experiencing the same problem reported here. It is not meant to indicate that Gradle is doing anything about this issue.

@KengoTODA we are still waiting to hear from you.

[JLLeitschuh]

Is there something holding up this being released?

[baron1405]

@KengoTODA please respond. We are getting to the point where the project may need to be forked and nobody wants that level of confusion if it can be so easily avoided.

[chali]

@KengoTODA I would like to suggest following change which should help to be compatible across Gradle versions. #40 Would you have time to review it? We would love to adopt the new version of Gradle as soon as it is out and this would be a blocker for us. Thank you.

[makkimesser]

Also I can't build my projects with SpotBugs Gradle Plugin 1.6.2 and Gradle 4.10 with the same error message. The PR chali suggested is quite simple and well documented. Why won't your apply it?

[henrik242]

A new version is on its way: #48

[baron1405]

I have emailed @KengoTODA asking him to merge #40 and create a release.

[chali]

I updated the example with today's gradle release candidate and the issue is still present.

[chali]

Some interesting findings. When I clone the project locally and build a snapshot version on my machine which I add to the example project I don't get the error.

[chali]

My findings are:

• When I build spotbugs-gradle-plugin with Gradle 4.7 (also with 4.8, 4.9) and consume it in a project with Gradle 4.10-rc-1 the project configuration fails.
• When I build spotbugs-gradle-plugin with Gradle 4.10-rc-1 and then consume it from a project with Gradle 4.10-rc-1 the project configuration is successful.

I found that the JDK version doesn't matter. I think changes in interfaces which ProjectInternal is implementing are the reason why this problem is appearing.

Gradle 4.9: interface ProjectInternal extends Project, ProjectIdentifier, FileOperations, ProcessOperations, DomainObjectContext, DependencyMetaDataProvider, ModelRegistryScope, PluginAwareInternal

Gradle 4.10-rc-1: interface ProjectInternal extends Project, ProjectIdentifier, HasFileOperations, DomainObjectContext, DependencyMetaDataProvider, ModelRegistryScope, PluginAwareInternal

[KengoTODA]

I'm not sure, but is it really OUR problem? The method reference is widely used in Java community, I guess (actually hope) that it's a Gradle side matter?

[KengoTODA]

I tried to build this project with Gradle version 4.10-rc-2 and 4.11-20180820000011+0000, and both of them can pass ./gradlew build in my local. I'll push a commit that runs build on these versions.

[chali]

Yes, I was able to build the plugin with those distributions without a problem too. The issue is when you try to consume plugin build against older gradle Gradle API in a project using a newer version. The method reference is used but the conversation I posted shows documented bugs in some corner cases which I believe we are seeing here https://stackoverflow.com/questions/33929304/weird-exception-invalid-receiver-type-class-java-lang-object-not-a-subtype-of The problem might be initiated by the change in Gradle but arguably this plugin is using internal API which shouldn't be consumed so hard to say whos problem is the issue. Without a new release, the plugin cannot be consumed in a project using Gradle 4.10.

[chali]

Example project mentioned in my issue shows the problem https://github.com/chali/spotbugsFailExample/tree/Gradle410LambdaConversionException. Would you, please, reconsider my PR #40

[JLLeitschuh]

Temporary release published for those craving a release.

WARNING: I'll might delete this release after 6 months to a year year out. If you need to do a git bisect with this version, you might want to avoid it and wait for an official release.

https://plugins.gradle.org/plugin/com.github.spotbugs.temporary

[baron1405]

Thank you @KengoTODA and @henrik242 for the 1.6.3 release! I just used it in my Gradle 4.10 build and it works great. Cheers!