Dogfooding - should classes be Serializable?

[spotbugs]

Dogfooding - should classes be Serializable?

[jsotuyod]

Most likely than not, none of those needs to be Serializable. I think we can remove those implements and see what breaks. Either you will get a compile error, or a brand new SE_BAD_FIELD report somewhere else on the chain.

The only of those that seems to have any reason to be Serializable is BugInstance due to the cloud plugins, but that is gone now, so it's most likely useless.

[mebigfatguy]

maybe BugInstance was for cloud? no idea

[jsotuyod]

I've been looking into this, it seems to stem down from the fact that MainFrame, as an awt component, is Seralizable.

AWT serialization is not used. It's mainly intended for Applets (not our case) and may be used for a sort-of prevalence, but it's not our intended use case either.

We should probably just mark those fields as transient on MainFrame, implement readObject with something along the lines:

    private void readObject(ObjectInputStream in) throws IOException, ClassNotFoundException {
        in.defaultReadObject();
        // re-init non-serializable fields
        logger = new ConsoleLogger(this);
        backgroundExecutor = Executors.newCachedThreadPool();
        mainFrameInitialized = new CountDownLatch(1);
        ....
    }

[mebigfatguy]

i think you can just rip it all out with impunity

[jsotuyod]

Yeah, that could also be, but we would have to suppress the SE_BAD_FIELD warnings on the awt compontents.

@ThrawnCA will you take this over now or shall someone else do it?

[jsotuyod]

Resolved on #85