Comments (4)
Yeah, height/width would be misleading for both the stroke and the value i.e. does 10 mean 10px or the value 10?
I think xLimit for YLine and yLimit for xLine would work!
from reactochart.
Hi @krissalvador27,
Just wanted to make sure I understand the expected behavior for the chart from the new prop that you are talking about. So this "stopper" prop would just take in a value that lies within the xDomain/yDomain, and cut the line short at the value provided right?
I've implemented it for the YLine by using the xScale function, but this is all based on my understanding (screenshot below):
Let me know if this is what you had in mind!
from reactochart.
Hey @tanayv
Yes! Your definition of the stopper prop is what I was envisioning and looks good based on the screenshot. I'm not sold on the prop name "stopper", but also can't think of anything better. Naming things is hard. 😅
from reactochart.
Sounds good!
Yes, I agree. "stopper" doesn't exactly convey what the prop is doing very well. What are your thoughts on something along the lines of xLimit for YLine and yLimit for XLine, or using just limit to keep it consistent across the two?
Something simple like height or width could also potentially work but I can see that being slightly confusing because it could mean the stroke width?
from reactochart.
Related Issues (20)
- Migrate to spotify/web-scripts HOT 19
- [Infra] Integrate cross-env into scripts using ENV variables HOT 2
- Deprecate numeral.js HOT 2
- YAxisLabels should calculate margin top and margin bottom using alignmentBaseline
- Reactochart Breaks with Fragments as Children HOT 5
- Add precommit hooks from spotify web-scripts HOT 2
- Decorate XYPlot onMouseEnter and onMouseLeave events HOT 5
- Console Warnings When Using React 16.9
- Convert test suite from mocha to jest HOT 1
- An in-range update of eslint-plugin-react is breaking the build 🚨 HOT 6
- Component props marked as required should not have defaults HOT 1
- An in-range update of css-loader is breaking the build 🚨 HOT 8
- An in-range update of webpack is breaking the build 🚨 HOT 7
- An in-range update of enzyme is breaking the build 🚨 HOT 12
- An in-range update of d3 is breaking the build 🚨 HOT 3
- Allow support for scaleUtc for xScaleType and yScaleType
- Allow users to override text anchor for XAxisLabels and YAxisLabels
- An in-range update of style-loader is breaking the build 🚨 HOT 3
- Minify output
- Not able to change layout in Histogram.js and Histogram.js.example accurately. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reactochart.