StepExecution needs a reference to JobExecution (or vice versa) [BATCH-33]

[spring-projects]

StepExecution needs a reference to JobExecution (or vice versa) [BATCH-33]

[spring-projects-issues]

Dave Syer commented

I think maybe the best thing is to extend the JobExecutionContext as a holder for the Job/Step/*Executions and make it responsible for maintaining the invariants (like every StepExecution has a JobExecution). Then StepExecutor and JobExecutor would use this directly in their interfaces, instead of Step/Job. And Job/Step could lose their (unnatural) reference to the JobExecutionContext.

[spring-projects-issues]

Dave Syer commented

Changed interface of *Executor to take a context object instead of the Job/Step. The will allow us to control the relationships and invariants.

TODO: clean up the executor code - scan for *ExecutionContext and extend the context interfaces to handle some of the schlepping that is being done by the executor.

TODO: change the data model to allow the StepExecution to know about its JobExecution, and make the link in the context helper methods.

[spring-projects-issues]

Dave Syer commented

The data mode is changed and relations are managed consistently. Made Step/Job unaware of the context - the context has to be aware of the entity anyway. There may still be an argument for moving more (or all) of the role of the execution contexts into the entity. For now there are still a few minor tidying tasks to do - e.g. to move some of the entity relationship management out of *Executor and into *ExecutionContext

[spring-projects-issues]

Dave Syer commented

Consolidated some of the creation logic (mainly for JobExecution) into *ExectionContext.

[spring-projects-issues]

Dave Syer commented

Assume closed as resolved and released