Is JobIdentifier really necessary? Maybe Job gives us everything we need. [BATCH-31]

[spring-projects]

Is JobIdentifier really necessary? Maybe Job gives us everything we need. [BATCH-31]

[spring-projects-issues]

Wayne Lund commented

We've always argued that you do need runtime information. The analogy we've used is with a metaphor from retail - the product and the SKU where product = JobRuntimeInformation and SKU = Job . The product is identified by the unique serial number of a physical instance and you can relate activities to it like warranties, support, etc. The SKU describes the product so that you can advertise and price it. In the case of JobRuntimeInformation we've said it's the instance of the job that we can associate statistics and monitoring with whereas Job is what we can schedule. If we can capture that type of two level logic with Job, which I don't think so, than we might get everything from Job.

[spring-projects-issues]

Dave Syer commented

I think maybe the two levels you mention are actually already represented as Job (as the root of a context and its entity sub-hierarchy) and JobConfiguration. JobConfiguration is what you schedule, and Job is where the statistics and monitoring happen. JobRuntimeInformation is only used to a) locate a JobConfiguration (by matching their names), and b) supply some of the "static" monitoring data, like stream name and schedule date. So as things stand, an instance of Job would be able to play exactly the same role as a JobRuntimeInformation (but not a JobConfiguration).

[spring-projects-issues]

Tommy C. Trang commented

I think we need both the Job and the JobRuntimeInformation because of the information they provide. The key information we need are job name, scheduled date, job runtime, and status.

[spring-projects-issues]

Dave Syer commented

I'm not sure what you mean then by "job runtime". If you mean the startDate then Job actually has all that already and all the other properties.

[spring-projects-issues]

Dave Syer commented

The discussion on this topic has really shifted since JobIdentifier was introduced. BATCH-58 and BATCH-84 are really the more relevant concerns now. Leaving this one open, but marking it as dependent.

[spring-projects-issues]

Dave Syer commented

The meaning of JobIdentifier is pretty much clear now - it's what you need to start / restart a job, but doesn't contain the exit status and execution dates etc.