Comments (6)
Dave Syer commented
ExitStatus from job execution could be correlated with BatchStatus as a sensible default. E.g. COMPLETED=0, FAILED=1, ... Currently it is just 0 (success), 1 (fail). The ExitStatus is only used for the exit code at the moment as well - there is room in the DDL for a message - so the whole exit status could be included in the database.
from spring-batch.
Stijn Maller commented
In the scope of our project we have implemented a few classes that do exactly what is described in this issue. I uploaded them as requested by Lucas Ward. We do depend on a few features of Java 5 which might be a problem for including it in spring-batch? (shouldn't be too hard to change that part of the code if needed)
from spring-batch.
Lucas Ward commented
I committed code that addresses this issue, based upon some of the code submitted by Stijn, and earlier code put in to fix BATCH-40. However, there still needs to be some polish applied (clean up java docs, etc), and I can't figure out a decent way to test the BatchCommandLineLauncher, since it makes a call to System.exit(). I'll finish it up tomorrow and mark as fixed.
from spring-batch.
Stijn Maller commented
I just uploaded the file spring-batch-execution-src-folder In which 2 things were changed:
- Tests were added to execute the BatchCommandLineLauncher in a new JVM
- The JvmExitCodeMapper now maps a more generic code for Configuration errors. (In adding this I moved a few constants around to more logical places)
from spring-batch.
Lucas Ward commented
BatchCommandLineLauncher now has unit tests and since it is correctly returning exit codes, I'm closing this issue and marking as fixed. I looked at the approach of kicking off an additional JVM, but I have some concerns about kicking off a new JVM within a unit test. If the current unit testing strategy is felt to be insufficient, a new issue can be opened for M3.
from spring-batch.
Dave Syer commented
I changed the unit test to use the SystemExiter strategy, so we don't need a separate JVM.
from spring-batch.
Related Issues (20)
- Schema Migration with Flyway HOT 2
- DELETE CASCADE on Foreign Keys HOT 6
- Spring Batch step write_count less than read_count and filter and skip counts are all zero HOT 1
- Incorrect Chunk property value in implementation of ItemWriter write method HOT 3
- 5.1.2 Backported issues HOT 1
- 5.0.6 Backported issues HOT 1
- remote partitioning doesn't work if you're using graalvm
- Access Job Description
- Kotlin data class support for `FlatFileItemReaderBuilder` HOT 4
- Deserialization of JobParameters throws exception
- Default value for ignoreWarnings in JdbcCursorItemReaderBuilder does not align with documentation HOT 1
- JdbcPagingItemReader - When using sortKeys with alias, I think it should paging by column name rather than alias in the select clause.
- MockStatic and MockConstruction not working in spring batch test cases HOT 1
- ListItemWriter<T>::getWrittenItems has bad wildcard return type HOT 1
- Data class support in JdbcCursorItemReaderBuilder & JdbcPagingItemReaderBuilder HOT 2
- Discrepancy in Thread Safety Documentation for AbstractPagingItemReader Subclasses
- Improve Error Messages in JobParametersBuilder methods
- The table field type in the SQL Server database is ntext and synchronized to the Oracle database, resulting in invalid column types in the corresponding NCLOB
- Add static variables to prevent typos in the metadata tables string path HOT 1
- Deprecate the usage of LobHandler HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spring-batch.