Comments (5)
Yes, it's meaningless unless the executor is internal. What matters is the configuration of the endpoint's executor. If you look at this.executor
in NioEndpoint
, you should see it using the configured value for its maximum threads.
from spring-boot.
Thanks for the report. The setting is working as expected and Tomcat's thread pool has a max size of 400. The problem is that the metric is incorrect.
I believe that the metric's incorrect due to #36087. It has changed the executor that Tomcat uses so it's no longer internal to the endpoint. This means that it returns -1
for its max threads:
public int getMaxThreads() {
if (internalExecutor) {
return maxThreads;
} else {
return -1;
}
}
from spring-boot.
Thank you for your kind reply. You actually said that Tomcat's maximum number of threads was set to 400, and the metric was incorrect.
But I debugged the part of code you mentioned, and maxThreads is 200. internalExecutor is false as you said. Is the value of 200 here meaningless?
It works normally in 3.2.6.
from spring-boot.
I've opened https://bz.apache.org/bugzilla/show_bug.cgi?id=69133 - if this is resolved, we can switch back to the default executor and set the queue size for #36087 via a normal setter.
from spring-boot.
Tomcat has added a setter to set the maximum queue size. When using this setter, this issue should go away. I've opened #41093 for that.
from spring-boot.
Related Issues (20)
- Release type conditionals are not working in documentation
- Extending DefaultErrorAttributes and overriding getErrorAttributes() gets called twice
- Reconsider use of DynamicPropertyRegistry in spring-boot-testcontainers HOT 1
- Migrating to Spring Boot v2 to v3 and Getting ClassNotFoundException for javax.xml.bind.annotation.XmlElement HOT 4
- Use FileSystemOperations rather than Project's sync and copy
- Use ArchiveOperations rather than Project's zipTree HOT 1
- Maven plugin integration tests cannot run against release local repository
- Maven plugin integration tests cannot run against release local repository
- Maven plugin integration tests cannot run against release local repository
- Use early static registration of EventPublishingContextWrapper in tests HOT 1
- Default Logback config uses deprecated "converterClass" attribute HOT 6
- AnonymousAuthenticationFilter bug HOT 3
- Default Logback config uses deprecated "converterClass" attribute
- Upgrade to ArchUnit 1.3.0
- Upgrade to ArchUnit 1.3.0
- Upgrade to ArchUnit 1.3.0
- New JarLauncher introduced in 3.2 fails to run huge jars. HOT 3
- DefaultErrorAttributes doesn't populate errors for MethodValidationResult HOT 6
- Add support for org.testcontainers.kafka.KafkaContainer HOT 2
- Maven 4 warnings from spring-boot-dependencies HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spring-boot.