Giter Site home page Giter Site logo

Comments (3)

wilkinsona avatar wilkinsona commented on July 28, 2024

Your YAML file above has defined two properties:

  • prefix.branch1.branch2conditioned.branch3a.value
  • prefix.branch1.branch2conditioned.branch3b.value

prefix.branch1.branch2conditioned doesn't exist as a property so it isn't matched.

If you want a condition that matches when any property whose name begins with prefix.branch1.branch2conditioned has been defined, you'll have to write your own Conditional implementation. It would have to examine all of the properties in the environment to see if any of them begin with prefix.branch1.branch2conditioned. Note that this will be imperfect as some PropertySources in the environment do not extend EnumerablePropertySource which means that they cannot list all of their properties. As such, your condition may not match when it should have done. This might not be a problem in your specific case as it will depend on the property sources that your application uses. JNDI is perhaps the most commonly used non-enumerable source.

from spring-boot.

lowcasz avatar lowcasz commented on July 28, 2024

Actually @ConditionalOnProperty(prefix ="prefix.branch1.branch2conditioned") generates exception due to missing name/value. I think it is great and intuitive place to add extra logic for the case when we have Map<String, ?> in property.
I would like to add this, because it is a common case and at first I thought it was a bug when I am able to map a property to a map.

Mapping to map can be usefull.
For simple example I have done it in this way:

public class PropertiesMapCondition implements Condition {

    private static final String property = "prefix.branch1.branch2conditioned";

    @Override
    public boolean matches(ConditionContext context, @Nullable AnnotatedTypeMetadata metadata) {
        return Binder.get(context.getEnvironment()).bind(property, HashMap.class).isBound();
    }

}

from spring-boot.

wilkinsona avatar wilkinsona commented on July 28, 2024

Actually @ConditionalOnProperty(prefix ="prefix.branch1.branch2conditioned") generates exception due to missing name/value

Yes, that's to be expected. I didn't say otherwise above.

When you bind properties to a map, the "property" that you're binding is actually the prefix. It's the keys that are added to the map that are the properties.

I still don't think this is generally useful and has a number of limitations as explained above. As such, it's better suited to a custom condition in your application where you can accommodate any limitations more easily. We can reconsider in the future if things change or there's significant demand for it.

from spring-boot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.