Comments (2)
Ok I investigated this.
Setup
- 2 files, one
.css
and one.scss
with the same code in them - 2 NPM scripts, running
sass-lint
using our config - Went through most of the rules in the
@springernature/sasslint-config
and created a CSS declaration for each one that should have failed the linting.
"scripts": {
"sasslint": "sass-lint --config ./node_modules/@springernature/sasslint-config/config/.sass-lint.yml './scss/*.scss' -v",
"sasslintcss": "sass-lint --config ./node_modules/@springernature/sasslint-config/config/.sass-lint.yml './css/*.css' -v",
}
Results
For the most part, sass-lint
caught the errors in the CSS as well as the SCSS. But it didn't catch all. The ones it didn't catch are shown below:
/**
--- space-before-brace ---
*/
/* Should fail but doesn't: Whitespace required before { */
.test{
color: aliceblue;
}
/**
--- indentation ---
*/
/* Should fail but doesn't - Mixed spaces and tabs */
.test {
color: aliceblue;
background: red;
}
/* Should fail but doesn't - Expected indentation of 1 tab but found 0 */
.test {
color: aliceblue;
background: red;
}
/* Should fail but doesn't - Expected indentation of 1 tab but found 0 */
.test {
color: aliceblue;
background: red;
}
/**
--- empty-line-between-blocks ---
*/
/* Should fail but doesn't: Space expected between blocks */
.test {
color: aliceblue;
}
.test {
color: aliceblue;
}
from frontend-playbook.
sass-lint is no longer been maintained/supported as of 2017. Should we be recommending stylelint and therefore need to update https://github.com/springernature/frontend-playbook/blob/main/css/house-style.md#linting
references
https://dev.to/stories_of_ren/switching-from-sass-lint-to-stylelint-5f8c
from frontend-playbook.
Related Issues (20)
- Update standards document so reflects the latest position on accessibility
- Improve the root README.md file
- Add some information about lazyloading to Performance section HOT 2
- Add information about sending ES6 / ES5 to different browsers HOT 3
- Add information about using polyfills
- Revisit secure markup page
- Open Sourcing 🧙 HOT 1
- Disable webfonts when prefers-reduced-motion is selected HOT 1
- Remove nesting section in BEM CSS part of the Frontend Playbook
- Document self-hosting static assets
- Add note on autofill to a11y checklist
- Provide a couple more examples of acceptable commenting HOT 1
- Document "mobile-first" approach to responsiveness and breakpoints
- Unbury the "how we make changes" page from its current hard-to-find location
- Guidelines for an "Enable JavaScript" messages on our sites HOT 2
- broken link
- Dead link to "http://pa11y.springernature.com/"
- Add a section on how we use SASS HOT 1
- Document that all links should have underlines in the Frontend Playbook
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from frontend-playbook.