DOM class variable issue with multiple engines (draftjs_exporter_markdown)

[springload]

DOM class variable issue with multiple engines (draftjs_exporter_markdown)

[thibaudcolas]

Hi @mjjo53, thanks for reporting this. Do you have some thoughts on what a fix would look like, or are you interested in contributing one? I’m interested in helping getting this working, but it will go much faster getting a fix done if you can drive this.

[thibaudcolas]

I just realised that I actually also ran into this issue on one of my projects, and solved it by manually re-setting the engine whenever calling render:

https://github.com/thibaudcolas/draftail-playground/blob/81ad38dd24bbc67a00ba93a751d8f4f8946d4268/markdown.py#L20-L22

def render_markdown(content_state):
    DOM.use(ENGINE)
    return exporter.render(content_state)

Does that seem like a viable solution to you? I think I might add this directly in exporter.render if so, so we can solve this without having to change how this code is structured too much.

[bindung]

@thibaudcolas
Your example code is not thread safe.

[thibaudcolas]

@bindung yes, as far as I know the whole library isn’t thread-safe, as @mjjo53 initially reported. The code above only helps in a single-threaded environment. Do you have any suggestions for how to fix this properly, or further diagnostic of the problem?