Long TEXT values show as (BLOB) since version 3.1.0

[sqlitebrowser]

Long TEXT values show as (BLOB) since version 3.1.0

[rp-]

Hi!

You are right this should be improved and is kinda already stated in the code:

bool SqliteTableModel::isBinary(const QModelIndex& index) const
{
    QByteArray val = m_data.at(index.row()).at(index.column());
    return val.size() > 1024 || val.contains('\0');     // Cheap BLOB test here...
}

We have to improve the isBinary() function

[rp-]

I also noticed that if you change the type to "TEXT" in the EditDialog, as soon as you edit something it will change back to binary mode, which is a pain and unusable.

[rp-]

Martin here is a small diff that would fix the 2 issues, any comments?

diff --git a/src/EditDialog.cpp b/src/EditDialog.cpp
index ae1703d..9257151 100644
--- a/src/EditDialog.cpp
+++ b/src/EditDialog.cpp
@@ -141,7 +141,7 @@ void EditDialog::checkDataType()
 {
     // Check if data is text only
     ui->comboEditor->setVisible(true);
-    if(QString(hexEdit->data()).toLatin1() == hexEdit->data())     // Any proper way??
+    if(QString(hexEdit->data()).toUtf8() == hexEdit->data())     // Any proper way??
     {
         ui->editorStack->setCurrentIndex(0);

diff --git a/src/sqlitetablemodel.cpp b/src/sqlitetablemodel.cpp
index 38b3cda..9ad9499 100644
--- a/src/sqlitetablemodel.cpp
+++ b/src/sqlitetablemodel.cpp
@@ -436,6 +436,6 @@ void SqliteTableModel::clearCache()

 bool SqliteTableModel::isBinary(const QModelIndex& index) const
 {
-    QByteArray val = m_data.at(index.row()).at(index.column());
-    return val.size() > 1024 || val.contains('\0');     // Cheap BLOB test here...
+    QByteArray val = m_data.at(index.row()).at(index.column()).left(1024);
+    return val.contains('\0');     // Cheap BLOB test here...
 }

[MKleusberg]

Looks good to me. Especially for the isBinary function we might need to come up with an even better version since this function is called quite often and left()+contains() probably isn't the fastest way to check this - but it's definitely an improvement this way!

[MKleusberg]

Just commited the patch. The problem should be fixed now - thanks Steve for pointing this out!

[justinclift]

Should we make a 3.1.1 with this fix in say a week (and whatever else turns up in the meantime)?

[justinclift]

Hmmm, thinking about this more, it's a bit iffy to close this without confirmation from the reporter that the problem is solved. It probably is solved, but just in case... 😄

@rp- Your nightly build - non-portable version - will have the fix in it won't it?

If that's the case, @stevehodgett would you be able to test it? Even though it's the non-portable version. http://rp.oldsch00l.com/sqlitebrowser/sqlitebrowser.exe.xz (but wait until tomorrow, when its freshly regenerated)

[stevehodgett]

Sure, I'll try it tomorrow and let you know.
Quick work!

[rp-]

yes the build tomorrow should have the fix, if there is no build error.
so before downloading check the file date or build log:
http://rp.oldsch00l.com/sqlitebrowser/

@MKleusberg How did you commit this patch as me? :)

[stevehodgett]

As predicted, Rene's fix works perfectly as far as I can see both for isBinary and for EditDialog::checkDataType() so, from my perspective, this issue is resolved.
(I do have a related EditDialog comment, but will raise a new issue for it)
Many thanks for the super quick fix!

[MKleusberg]

@rp- Here is what I did:
git apply yourpatch.diff
git commit -a --author='Peinthor Rene [email protected]'
This leads to a commit where committer!=author just like when applying changes from a foreign repository. Hope you didn't mind 😀

[rp-]

na it's cool, just thought there is some hidden github button for that :)