[Bug]: Some links in About window have http protocol rather than https

[rafrafek]

[Bug]: Some links in About window have http protocol rather than https

[lucydodo]

Good point. Thank you for checking it out.

Qt License can be replaced with the following link: https://doc.qt.io/qt-5/licensing.html
Also, Silk Icon Set can be replaced with the following link: https://github.com/markjames/famfamfam-silk-icons

[justinclift]

Good point. We should update that for the links that do have https ones available.

Hmmm, want to make a PR with that change? 😄

[justinclift]

Why do the translation files have TypeScript file extension (.ts)

Pretty sure that extension has been .ts for many years before TypeScript was invented. 😉

[justinclift]

Should I just change http to https or should I replace the link?

I'd just change http to https where that works. ie where the new link is valid

If there's a situation where the new link isn't valid, then changing the complete url is probably the next step. 😄

[rafrafek]

I'm getting 404 for:

http://qt-project.org/doc/qt-5/licensing.html

and

http://www.famfamfam.com/lab/icons/silk/

[rafrafek]

http://qt-project.org/doc/qt-5/licensing.html was already changed on master. But it was changed to

https://qt-project.org/doc/qt-5/licensing.html

which also gives me 404, so I've updated it to https://doc.qt.io/qt-5/licensing.html

[justinclift]

Probably not. That sounds like something we should ask the translators for those languages to do. 😄

[rafrafek]

I think the lacking ones may be actually correct since there are new icons being used on the master branch. 😅

[rafrafek]

Yep, let me try.

[rafrafek]

http://www.gnu.org/licenses/gpl.html redirects to https://www.gnu.org/licenses/gpl-3.0.html

Should I just change http to https or should I replace the link?

[rafrafek]

Why do the translation files have TypeScript file extension (.ts) rather than the actual type (xml)?

It makes my editor going crazy 😅.

[rafrafek]

http://www.famfamfam.com/lab/icons/silk/ is not present in all the translation files:

Should I add it to the six files lacking it?

[justinclift]

Ahhh. Hadn't thought of that. I guess we'll figure it out more the next time our translators look at it. 😄