[Bug]: Copying data to clipboard takes too long

[i-s-o]

[Bug]: Copying data to clipboard takes too long

[i-s-o]

I tried the latest changes: they seem to have halved the time to copy the data to the clipboard, which makes sense, since your changes skip building the SQL insert string with Ctrl+C. As a data point:

• Copying the first 4 columns now takes 9sec (down from 15sec)
• Copying the first 7 columns now takes 27sec (down from 50sec)
• Copying the entire table now takes 5min 5sec

I don't want to include new strings for translations for the next release

Agreed. Nevertheless, a progress report would be very helpful (probably would still require new strings to be translated).

One improvement with no translation required: let the Esc key cancel the operation.

[mgrojo]

Implemented.

[justinclift]

probably would still require new strings to be translated

Not if we've used a generic description for a progress bar elsewhere. 😁

From rough memory I think @MKleusberg added a progress bar for downloading remote databases via the remote tab (a few years ago). 😉

[mgrojo]

Ok, there's a wonder called QProgressDialog which can make that without any new string. I'm working on adding it.

[justinclift]

Heh Heh Heh, that's a pretty good turnaround time. 😄

[mgrojo]

@i-s-o I've optimized as much as I could without changing the behaviour, because I don't want to include new strings for translations for the next release, and also for minimizing risk. Splitting the HTML and the plain text version is only way to get important gains, but it will have to wait until I have more time.

Please, give it a try, so we can minimize the chance of getting any bug in the release.

[i-s-o]

This is a big improvement and I think it will eliminate any UX surprises.

I had two unexpected observations:

1. The question mark in the title bar is presumably the "Help" button, but it is not connected to any further action. Rather, clicking on it changes the cursor, but that cursor seems to get stuck even after the dialog box closes. In one of my tests, it was stuck until I exited the app. In other tests, it reverted to the standard cursor once I clicked somewhere in the app. It would best if it wasn't shown (if that is an option).
   
   Later after the copy task was completed (in Exec SQL tab):
   
2. The progress dialog is not consistent on subsequent runs:
   a. The green progress indicator showed in about 2 out of 10 tests. It was just blank for the remaining interactions.
   b. In about 50% interactions it showed a 0% next to which didn't increment until the task was complete: I think not showing it is a better option if it's not going the reflect the task's actual progress.
   
   vs
   
   vs
   

[mgrojo]

I've made a commit to disable the context help button on all progress dialogs. Can you confirm it is removing the button on Windows? I'm testing on Linux.

The progress dialog is not consistent on subsequent runs:
a. The green progress indicator showed in about 2 out of 10 tests. It was just blank for the remaining interactions.
b. In about 50% interactions it showed a 0% next to which didn't increment until the task was complete: I think not showing it is a better option if it's not going the reflect the task's actual progress.

Is this always doing a copy operation? I've never seen the green bar, or that it doesn't work as expected (except for my preliminary trials).

[i-s-o]

Yes, the context help button is gone.

I've never seen the green bar

FYI the following is a screen capture of back to back Ctrl+C (or Ctrl+Shift+C): most of the time, I get the blank progress box (I didn't record all of them). I couldn't figure out a way to trigger a specific behavior.

DB_Browser_for_SQLite_20240624-173712.mp4