Giter Site home page Giter Site logo

Comments (6)

sqren avatar sqren commented on July 27, 2024 1

@brianmcgue Yes, this is exactly how I determine which commits have been backported:
Screen Shot 2019-09-16 at 14 40 20

This approach is also tells whether a backport PR has been created (grey) or merged in (green); and to which versions.
I was thinking of extracting this logic, so we can have a daily job that verifies that all PRs to master are backported within 48 hours or something like it. And post a comment on the PR if a backport is missing.

@spalger I've created a PR that adds the option backport-created-labels (I'm open to better naming suggestions).

from backport.

FrankHassanabad avatar FrankHassanabad commented on July 27, 2024

That sounds like an improvement so ++

from backport.

acrewdson avatar acrewdson commented on July 27, 2024

+1 for this and also for making the label name configurable in config.json

from backport.

sqren avatar sqren commented on July 27, 2024

Cool, what do you think the option should be called? There is already labels which are the labels added to the backport PRs:

// Example .backportrc.json
{
  "upstream": "elastic/kibana",
  "branches": [{ "name": "7.x", "checked": true }, "7.4", "7.3"],
  "labels": ["backport"]
}

I was thinking about originalPRLabels, statusLabels, successLabels, postBackportLabels. None of them are great. Input much appreciated.

from backport.

acrewdson avatar acrewdson commented on July 27, 2024

originalPRLabels seems pretty good to me, but yeah, it's a tough one

from backport.

brianmcgue avatar brianmcgue commented on July 27, 2024

GitHub's reference links are useful when it comes to this. And since each commit message in the PR references its original PR, they should always show up. But this would still be useful when filtering PRs and for quick reference checks 👍
Screen Shot 2019-09-06 at 11 01 35 AM

from backport.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.