Comments (6)
@brianmcgue Yes, this is exactly how I determine which commits have been backported:
This approach is also tells whether a backport PR has been created (grey) or merged in (green); and to which versions.
I was thinking of extracting this logic, so we can have a daily job that verifies that all PRs to master are backported within 48 hours or something like it. And post a comment on the PR if a backport is missing.
@spalger I've created a PR that adds the option backport-created-labels
(I'm open to better naming suggestions).
from backport.
That sounds like an improvement so ++
from backport.
+1 for this and also for making the label name configurable in config.json
from backport.
Cool, what do you think the option should be called? There is already labels
which are the labels added to the backport PRs:
// Example .backportrc.json
{
"upstream": "elastic/kibana",
"branches": [{ "name": "7.x", "checked": true }, "7.4", "7.3"],
"labels": ["backport"]
}
I was thinking about originalPRLabels
, statusLabels
, successLabels
, postBackportLabels
. None of them are great. Input much appreciated.
from backport.
originalPRLabels
seems pretty good to me, but yeah, it's a tough one
from backport.
GitHub's reference links are useful when it comes to this. And since each commit message in the PR references its original PR, they should always show up. But this would still be useful when filtering PRs and for quick reference checks 👍
from backport.
Related Issues (20)
- ChainAlert: npm package release (8.3.0) has no matching tag in this repo
- Add support for signed commits
- How backport tool can be used to local repo? HOT 1
- Add support for dynamic `targetPRLabels` HOT 7
- Backport --pr only backports one commit even if PR merged multiple commits into target branch HOT 8
- Unhandled Error in Backport CLI - Code 128 "Not a valid commit name" HOT 1
- Explain configuration option: config-file HOT 4
- Backport always performs a clone HOT 6
- branchLabelMapping 1:n mapping HOT 3
- Backport GH action & merge conflicts HOT 2
- Can this be tool used with GitLab? HOT 1
- Unexpected token . HOT 5
- v8.9.7 - Cannot read properties of undefined HOT 1
- Add support for dynamic `sourcePRLabels`
- Provide the upstream PR title as a template variable to build the backported PRs title HOT 4
- Option to copy labels from target to source HOT 5
- Workflow permission is required for pushing changes
- List of releases is out of date HOT 1
- `No target branches found for this PR` error HOT 7
- Query `CommitsByAuthor` gets 502 error in Github response when using large `maxNumber` HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from backport.