Giter Site home page Giter Site logo

Comments (3)

sqren avatar sqren commented on July 27, 2024

The additional labels would enable us to create reminders in slack with the Github bot if backports for our team are remaining open due to build failures.

This makes a lot of sense. Your suggested approach would send reminders for unmerged backport PRs. While this can be useful, it will miss backports that were never created in the first place. This is often the case when a backport has conflicts.

One example I found for the Security team is this PR. It was supposed to be backported to 8.0, 7.17 and 7.16 but 7.17 and 7.16 failed due to conflicts. The 7.16 label was removed but it looks like it was still intended to be backported to 7.17. This never happened.

You can already find out all of this with existing functionality:

backport --pr-filter 'Team: Detection Alerts' --all --only-missing -n 50 --json --ls | jq

(assumes that you have jq installed). If you want to do this programatically you are better off using the API instead of the cli above.

Let me know if that makes sense and works for you. Will gladly make changes and improvements where needed.

from backport.

sqren avatar sqren commented on July 27, 2024

Hi @marshallmain

I'm revisiting this issue again.

A wildcard-like capability would be important here so we can define that any Team:* labels get copied over but other labels don't

Where do you imagine this to be defined? In the .backportrc.json or somewhere else?

from backport.

sqren avatar sqren commented on July 27, 2024

Closing due to inactivity. Feel free to comment if this comes up again.

from backport.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.