Comments (3)
The additional labels would enable us to create reminders in slack with the Github bot if backports for our team are remaining open due to build failures.
This makes a lot of sense. Your suggested approach would send reminders for unmerged backport PRs. While this can be useful, it will miss backports that were never created in the first place. This is often the case when a backport has conflicts.
One example I found for the Security team is this PR. It was supposed to be backported to 8.0, 7.17 and 7.16 but 7.17 and 7.16 failed due to conflicts. The 7.16 label was removed but it looks like it was still intended to be backported to 7.17. This never happened.
You can already find out all of this with existing functionality:
backport --pr-filter 'Team: Detection Alerts' --all --only-missing -n 50 --json --ls | jq
(assumes that you have jq
installed). If you want to do this programatically you are better off using the API instead of the cli above.
Let me know if that makes sense and works for you. Will gladly make changes and improvements where needed.
from backport.
I'm revisiting this issue again.
A wildcard-like capability would be important here so we can define that any
Team:*
labels get copied over but other labels don't
Where do you imagine this to be defined? In the .backportrc.json
or somewhere else?
from backport.
Closing due to inactivity. Feel free to comment if this comes up again.
from backport.
Related Issues (20)
- ChainAlert: npm package release (8.0.0) has no matching tag in this repo
- Allow for just a link instead of a `img.shields.io` image HOT 1
- ChainAlert: npm package release (8.3.0) has no matching tag in this repo
- Add support for signed commits
- How backport tool can be used to local repo? HOT 1
- Add support for dynamic `targetPRLabels` HOT 7
- Backport --pr only backports one commit even if PR merged multiple commits into target branch HOT 8
- Unhandled Error in Backport CLI - Code 128 "Not a valid commit name" HOT 1
- Explain configuration option: config-file HOT 4
- Backport always performs a clone HOT 6
- branchLabelMapping 1:n mapping HOT 3
- Backport GH action & merge conflicts HOT 2
- Can this be tool used with GitLab? HOT 1
- Unexpected token . HOT 5
- v8.9.7 - Cannot read properties of undefined HOT 1
- Add support for dynamic `sourcePRLabels`
- Provide the upstream PR title as a template variable to build the backported PRs title HOT 4
- Option to copy labels from target to source HOT 5
- Workflow permission is required for pushing changes
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from backport.