can't emit primary constructor default parameters

[square]

can't emit primary constructor default parameters

[burntcookie90]

  @Test fun constructorWithDefaultParamValue() {
    val type = TypeSpec.classBuilder("Taco")
        .primaryConstructor(FunSpec.constructorBuilder()
            .addParameter(ParameterSpec.builder("a", Int::class).defaultValue("1").build())
            .addParameter(ParameterSpec.builder("b", String::class.asTypeName().asNullable())
                .defaultValue("null")
                .build())
            .build())
        .addProperty(PropertySpec.builder("a", Int::class)
            .initializer("a")
            .build())
        .addProperty(PropertySpec.builder("b", String::class.asTypeName().asNullable())
            .initializer("b")
            .build())
        .build()

    assertThat(toString(type)).isEqualTo("""
        |package com.squareup.tacos
        |
        |import kotlin.Int
        |import kotlin.String
        |
        |class Taco(val a: Int = 1, val b: kotlin.String? = null)
        |""".trimMargin())
  }

actual output:

class Taco(val a: Int, val b: kotlin.String?)

There's a withInitializer flag when emitting the primaryConstructor paramters, I'll try and take a look at debugging this tomorrow.

[burntcookie90]

whoops, missed defaultValue 🤦‍♂️

[burntcookie90]

Ok, sorry for the goof, I'm re-opening because the exact code block above can't be generated.

[JakeWharton]

What did you try? My guess would be a constructor param with a default and then a property which is initialized to the constructor param.

…

On Sun, Jun 18, 2017, 9:23 PM Vishnu Rajeevan ***@***.***> wrote: Reopened #133 <#133>. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#133 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEEEdxW-JtENNbTFEWJGwk5piyfj-pZks5sFc2EgaJpZM4N9qAM> .

[burntcookie90]

I tried that but it moves initialization out of the inline syntax. I'll paste a code sample when I'm not afk. On Sun, Jun 18, 2017, 10:02 PM Jake Wharton <[email protected]> wrote:

…

What did you try? My guess would be a constructor param with a default and then a property which is initialized to the constructor param. On Sun, Jun 18, 2017, 9:23 PM Vishnu Rajeevan ***@***.***> wrote: > Reopened #133 <#133>. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#133 (comment)>, or mute > the thread > < https://github.com/notifications/unsubscribe-auth/AAEEEdxW-JtENNbTFEWJGwk5piyfj-pZks5sFc2EgaJpZM4N9qAM > > . > — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#133 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABYqRXNYacNu634Uo1uOVZN5N0Qvi_3hks5sFda8gaJpZM4N9qAM> .