Giter Site home page Giter Site logo

Comments (5)

pyricau avatar pyricau commented on May 6, 2024

Cool!

While this fixes the leak, I assume it also prevents from receiving the user selection. So I'm guessing you're calling that code once the activity is destroyed?

It would be nice if you could:

  1. File an issue on http://b.android.com , with the API version, an explanation, the leak trace, and a simple repro case, and cross link the issue here with that issue there.
  2. Do a PR to update AndroidExcludedRefs (and maybe write the hack as a gist and link to it from there)

from leakcanary.

andaag avatar andaag commented on May 6, 2024

I'm actually calling that code in onDetachedFromView, although on activity death would work. I'll make a PR and a fix a proper bugreport.

from leakcanary.

andaag avatar andaag commented on May 6, 2024

Bug report : https://code.google.com/p/android/issues/detail?id=172659&thanks=172659&ts=1431419348

from leakcanary.

pyricau avatar pyricau commented on May 6, 2024

@andaag the sample you wrote in the bug report demonstrate the bug in support v7. That's not the original one you had, which was in AOSP. You should probably update the sample, otherwise you risk being dismissed.

Also, what version of the Android API are you using? This should be included in the bug report as well. And if it's not 22, please reproduce with 22.

from leakcanary.

pyricau avatar pyricau commented on May 6, 2024

If possible, the bug report should also explain what is causing the bug (what assumptions are wrong), and what they can do to fix it.

from leakcanary.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.