POST not work with @field annotaion

[calidion]

POST not work with @field annotaion

[JakeWharton]

Here's a test case showcasing that it can work:

retrofit/retrofit/src/test/java/retrofit2/RequestFactoryTest.java

Lines 2608 to 2621 in 23d0461

	@Test
	public void simpleFormEncoded() {
	class Example {
	@FormUrlEncoded //
	@POST("/foo") //
	Call<ResponseBody> method(@Field("foo") String foo, @Field("ping") String ping) {
	return null;
	}
	}
	Request request = buildRequest(Example.class, "bar", "pong");
	RequestBody body = request.body();
	assertBody(body, "foo=bar&ping=pong");
	assertThat(body.contentType().toString()).isEqualTo("application/x-www-form-urlencoded");
	}

Please supply a failing test case if you think something is broken.

[calidion]

I think this simple test may be not sufficient.
I have seem a lot of question on why field is not working.
no one can give a working answer.
I am now using okhttpclient instead.

[calidion]

this is the code working with OkHttpClient:

        public String quota(String username , String password) {
        RequestBody formBody = new FormBody.Builder()
                .add("username", username)
                .add("password", password)
                .build();

        Request request = new Request.Builder()
                .url(BASE_URL + "user/quota")
                .post(formBody)
                .build();

        Call call = httpClient.newCall(request);
            try {
                Response response = call.execute();
                return response.body().string();
            } catch (IOException e) {
                throw new RuntimeException(e);
            }
        }

[calidion]

this is the code not working with retrofit2:

    public Quota quota;
    OkHttpClient.Builder httpClient = new OkHttpClient.Builder();

    public void start(String username, String password) {
        Gson gson = new GsonBuilder()
                .setLenient()
                .create();

        Retrofit retrofit = new Retrofit.Builder()
                .baseUrl(BASE_URL)
                .addConverterFactory(GsonConverterFactory.create(gson))
                .client(httpClient.build())
                .build();

        APIService apiService = retrofit.create(APIService.class);

        Call<Quota> quotaCall = apiService.getQuota(username, password);
        quotaCall.enqueue(this);
    }

    @Override
    public void onResponse(Call<Quota> call, Response<Quota> response) {
        if (response.isSuccessful()) {
            quota = response.body();
        } else {
            System.out.println(response.errorBody());
        }
    }

    @Override
    public void onFailure(Call<Quota> call, Throwable t) {
        t.printStackTrace();
    }

public interface Quota {
    public String username = "";
    public int quota = 0;
    public int upload = 0;
    public int download = 0;
}

public interface APIService {
    @GET("servers")
    void getServers();

    @FormUrlEncoded
    @POST("user/quota")
    Call<Quota> getQuota(@Field("username") String username, @Field("password") String password);

}

[JakeWharton]

How is it not working?

[calidion]

How is it not working?

I can't trace much deeper.
I only know that the parameters are passed into the requester.

[calidion]

@JakeWharton

https://github.com/Free-Web-Movement/android-base-library

this is a repository can reproduce this bug.
Where OKHTTP works well and @field not .

[JakeWharton]

Retrofit's @FormUrlEncoded uses OkHttp's FormBody.Builder to build the body the same as your snippet does.

retrofit/retrofit/src/main/java/retrofit2/RequestBuilder.java

Lines 89 to 91 in 87e0c81

	if (isFormEncoded) {
	// Will be set to 'body' in 'build'.
	formBuilder = new FormBody.Builder();

I need a self-contained test case to debug anything here, so I'm going to preemptively close. If you can come up with a failing test case I can take a look.

[calidion]

this is the failing test case and you don't take a look.
And there is only one test!

[calidion]

https://github.com/Free-Web-Movement/android-base-library
is the simplest example that showing how @field fails.
if you don't have the ability to debug, then you'd better resign or close source this project.