Comments (5)
The main reason is that the queue is not safe for concurrent interaction. A quick glance at the BlockingQueue
docs and your gist makes it seem like you are not fulfilling the contract of the interface:
BlockingQueue
implementations are thread-safe.
from tape.
All operations to the backing QueueFile are synchronized, so there is no concurrent access to the QueueFile (unless of course someone shares the QueueFile instances to other places). This is similar to the ArrayBlockingQueue which synchronizes every operation to the backing array.
I've missed the locking in the add() method, but that's fixed locally.
from tape.
Ah, haha. The add
method was the only one I looked at!
I don't think I'm opposed to adding this if you're willing to send a PR and write tests.
from tape.
Is this project still alive?
from tape.
Used a lot of places but not heavily developed as it's pretty mature. I think there's a branch with a 2.0 proposal. -- https://github.com/square/tape/tree/2.0.0-RC1
from tape.
Related Issues (20)
- Is it thread safe? HOT 3
- Android module for android specific logic HOT 2
- A question about the evolution of this repository HOT 1
- Read/Write Benchmarks HOT 1
- Application not responding after adding an entry to the queue HOT 2
- Batched remove() - Using remove() less frequently than peek() HOT 6
- Remove java.io.OutputStream and the like from API?
- Wrap QueueFile around an existing File? HOT 6
- Support addAll(Collection<byte[]>) for better performance with small records HOT 2
- Windows non-sync writes HOT 1
- Fail to read queue.
- Leak of file descriptor when creating QueueFile from corrupted queue file. HOT 1
- Not compatible with Gradle 5.1.1 HOT 6
- Why so slow?
- QueueFileTest.testSaturatedFileExpansionMovesElements hanged HOT 3
- Issues while writing and reading from different daemons with flock
- Consider DequeFile HOT 1
- Fail to Remove from FileObjectQueue
- Time to mark as deprecated? HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tape.