Item Y coordinate -- possible value range conflict with stash page size

[squeek502]

Item Y coordinate -- possible value range conflict with stash page size

[squeek502]

Sounds reasonable, you're probably right. I'll look into it more; there might be something in the PlugY source that is useful as well.

[squeek502]

So I think this 3/4-bit variance is actually vanilla D2 behavior that depends on the gridY value in Inventory.txt.

• PlugY injects its modified stash size here by modifying the compiled Inventory.txt values directly, but doesn't change anything else related to the Y coordinate of saved items.
• If you change Inventory.txt to use a gridY of 10 and use -direct -txt, Diablo II will start saving Y values using the 4th bit. Very strange behavior to vary the bit width depending on the max value if you're just going to use a padding bit when writing the 3-bit value anyway, but that seems to be what's going on AFAICT

So, in order to be compatible with mods like this we'll need to know the contents of Inventory.txt while reading items, and then when reading PlugY stash items we just need to tell the reader that gridY is actually 10 so we read the Y pos as a 4-bit value.

Very good catch, thank you for creating the issue!

Some more stuff:

• PlugY stash organizer that reads Y pos as 4 bits
• Another PlugY stash organizer that reads Y pos as 4 bits

[squeek502]

Actually, I overthought it. The fix is as simple as unconditionally reading the 4-bit value, since the bit ordering means that 1 would be 1000, and 9 would be 1001 (i.e. the 'unknown' bit is only set if the actual value is large enough to warrant it, which explains why it was labeled 'unknown' by people only looking at vanilla D2 saves since it would never be non-zero without Inventory.txt changes).

Will fix the library and docs.