Giter Site home page Giter Site logo

Comments (6)

RomainBillot avatar RomainBillot commented on May 3, 2024 1

I think it's better to have the 'latest' module version working for 'latest' terraform version, no?
If so, you could document which versions works for which terraform version?

from terraform-aws-api-gateway-enable-cors.

davetc4k avatar davetc4k commented on May 3, 2024

headers = tomap(
{
"Access-Control-Allow-Headers" = "'${join(",", var.allow_headers)}'",
"Access-Control-Allow-Methods" = "'${join(",", var.allow_methods)}'",
"Access-Control-Allow-Origin"= "'${var.allow_origin}'",
"Access-Control-Max-Age" = "'${var.allow_max_age}'",
"Access-Control-Allow-Credentials"= var.allow_credentials ? "'true'" : ""
}
)

Will do a PR if required

from terraform-aws-api-gateway-enable-cors.

squidfunk avatar squidfunk commented on May 3, 2024

Yes, a PR would be great!

from terraform-aws-api-gateway-enable-cors.

RomainBillot avatar RomainBillot commented on May 3, 2024

But a revert has been done on April last year. Shouldn't we provide different versions of this one ?

from terraform-aws-api-gateway-enable-cors.

squidfunk avatar squidfunk commented on May 3, 2024

The revert you're speaking of been done in #14. I'm currently not using this module myself, so I'm not sure how we should proceed here.

from terraform-aws-api-gateway-enable-cors.

squidfunk avatar squidfunk commented on May 3, 2024

I'm afraid I have no time to work on this. I can give you collaborator access if you like.

from terraform-aws-api-gateway-enable-cors.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.