Comments (6)
I think it's better to have the 'latest' module version working for 'latest' terraform version, no?
If so, you could document which versions works for which terraform version?
from terraform-aws-api-gateway-enable-cors.
headers = tomap(
{
"Access-Control-Allow-Headers" = "'${join(",", var.allow_headers)}'",
"Access-Control-Allow-Methods" = "'${join(",", var.allow_methods)}'",
"Access-Control-Allow-Origin"= "'${var.allow_origin}'",
"Access-Control-Max-Age" = "'${var.allow_max_age}'",
"Access-Control-Allow-Credentials"= var.allow_credentials ? "'true'" : ""
}
)
Will do a PR if required
from terraform-aws-api-gateway-enable-cors.
Yes, a PR would be great!
from terraform-aws-api-gateway-enable-cors.
But a revert has been done on April last year. Shouldn't we provide different versions of this one ?
from terraform-aws-api-gateway-enable-cors.
The revert you're speaking of been done in #14. I'm currently not using this module myself, so I'm not sure how we should proceed here.
from terraform-aws-api-gateway-enable-cors.
I'm afraid I have no time to work on this. I can give you collaborator access if you like.
from terraform-aws-api-gateway-enable-cors.
Related Issues (7)
- Using Binary Media Types in API Gateway causes OPTIONS requests failing with 500 errors HOT 1
- Failing on Terraform 0.15 HOT 4
- Enabled CORS for nested resources HOT 1
- just wanted to say thank you! HOT 1
- Deprecation warnings after upgrading to Terraform 0.12 HOT 1
- Error: Error creating API Gateway Method: NotFoundException: Invalid Resource identifier specified
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terraform-aws-api-gateway-enable-cors.