Forbiddenfunctions visibility change?

[squizlabs]

Forbiddenfunctions visibility change?

[gsherwood]

Yes, it was changed to provide this feature: #263

[adamculp]

So, this leads to a question: If I alter visibility to match the new 'public', will this render sniffs broken if we set https://github.com/wimg/PHPCompatibility to match and someone uses the old version of Codesniffer which is still set to "protected"?

Basically, is it looking for a 1 to 1 match on visibility or is it requiring equal to or more permissive than Codesniffer extended sniff? (see https://github.com/wimg/PHPCompatibility/blob/master/Sniffs/PHP/NewFunctionsSniff.php for reference)

[gsherwood]

If you want to support both 1.x and 2.x for a custom standard, you'll probably need 2 versions of your standard. So many things have changed in 2.x that maintaining backwards compatibility is very hard. Possible, depending on what you do, but difficult.

For your specific case, PHP_CodeSniffer itself is not looking for anything. PHP will be the one checking the visibility and throwing an error if it doesn't match.

If you don't want to version your standard, you're probably better off not extending the ForbiddenFunctions sniff at all. Either that, you you create a wrapper sniff for the check and then either include the old class or the new class depending on the PHPCS version. If $phpcsFile->fixer exists, you know it is 2.x