Giter Site home page Giter Site logo

Comments (4)

oliverklee avatar oliverklee commented on May 6, 2024

PHP 5.3 has reached its end of life on 2013-06-11 anyway: http://php.net/archive/2013.php#id2013-07-11-1

from php_codesniffer.

aik099 avatar aik099 commented on May 6, 2024

Some projects are so happy about, that they have set their minimum PHP version requirement to PHP 5.4 already. However fact, that PHP is quick about releasing new versions doesn't mean that amount of projects (and legacy code) still using it suddenly becomes smaller.

I think PHP_CodeSniffer should tolerate PHP version-specific code and don't enforce upgrade to next PHP version.

from php_codesniffer.

gsherwood avatar gsherwood commented on May 6, 2024

PHP_CodeSniffer doesn't enforce anything; it is the standard that enforces things. If you don't like the standard, change it, customise it, or make your own.

from php_codesniffer.

aik099 avatar aik099 commented on May 6, 2024

Code is located in Squiz.Commenting.FunctionComment sniff's processParams method, which is 306 lines long with no way for easy overriding.

Overriding that long method will prevent me from getting any improvements to that sniff in future. That's what I'm worried about.

That's actually well known problem in sniffs: too long process method with no easy way to change small bits of sniff logic without overriding long methods.

from php_codesniffer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.