1 pixel line on iOS when using offset

[srbrahma]

1 pixel line on iOS when using offset

[SrBrahma]

Thanks!

If you change the offset to offset={[-5, -5]}, does it also happens for the top and left sides?

Looks like it's a paintInside issue. The corners and sides contacts seems to be ok.

I think I found the cause: In the line 432 (in TS source),

react-native-shadow-2/src/index.tsx

Line 432 in aaf5dee

<Rect width={width} height={height} mask='url(#maskPaintBelow)' fill={startColorWoOpacity} fillOpacity={startColorOpacity}/>

, there is "width={width} height={height}".

In the transpiled .js file, it's on the line 240. You can give it a try and edit the node_modules/react-native-shadow-2/lib/index.js and replace what I quoted with width={widthWithAdditional} height={heightWithAdditional}. I think it will work, as by having a smaller width and height, the SVG gets shortened, specially on high dp screens, as your iPhone must be. What is your iPhone model?

If it fixes it, I will release it asap.

Edit: Hmmm... actually, it shouldn't be the cause of this issue. The wrapping svg already has the withAdditional. Maybe changing it would cause overlaps on smaller dps. Anyway, give it a try.

[SrBrahma]

Also, please, make a minimal reproducible example in Expo Snack (iOS), so if I can get this issue here I won't have to make you try different stuff.

[walterholohan]

@SrBrahma thanks for the quick reply, I have tried editing line 240 above but that did not fix the issue.

Below is a screenshot of offset={[-5, -5]}, you can see that they are some 1 pixel lines visible

[walterholohan]

Also, the issue is visible on your snack, just change the shadow color to a darker color - https://snack.expo.dev/@srbrahma/react-native-shadow-2-sandbox

I am using an iPhone Xs

[SrBrahma]

Hi, @walterholohan.

Big text ahead just for future references:

I managed to get the issue on my iPhone 8. As it doesn't have a high dp and has the same issue, this seems it's an issue caused by how react-native-svg handles masks on iOS, a svg tag that paintInside uses. It doesn't seem to be predictable on iOS. Sometimes an x/y positioning of like +1 would fix it, sometimes not. Changing the size or positioning would change its thickness somewhat randomly. In your image, you can see that some lines are thicker than others:

I've managed to get a solution: on 2nd render and beyond (or when size property is defined), we use a simple <Path/> SVG component to exactly paint the internal of the shadow.

<Path fill={startColor} d={`M0,${topLeft} v${height - bottomLeft - topLeft} h${bottomLeft} v${bottomLeft} h${width - bottomLeft - bottomRight} v${-bottomRight} h${bottomRight} v${-height + bottomRight + topRight} h${-topRight} v${-topRight} h${-width + topLeft + topRight} v${topLeft} Z`}/>

I can't do this on the first render as the Path doesn't accept percentage values, only numbers.

We could do this on the first render if we smartly placed rectangles inside the hole, but it's a quite hard task, as each corner may have different radii. You can see this if you imagine a square and at each corner you remove a square of a random size. What algorithm would you use to always fill the entire hole without overlaps, as overlaps would mess the internal color, as it may have transparency? Also, doing this wouldn't give a guarantee that it wouldn't also give gaps.

On the first render, the current mask solution is still used, so the gaps will briefly show up. But, on a 60fps screen, 1px line and for something that just appeared, it isn't noticeable for common eyes.

tl;dr, Released 6.0.3 via 2f3001f!

Please, tell me if it worked for you!

[SrBrahma]

If you think that those lines are noticeable on the first render, I could really use a hand on that rectangles algorithm. I am really out of time to do it right now.

[SrBrahma]

This was recently merged on react-native-svg on 12.3.0: software-mansion/react-native-svg#1658

As it both mentions iOS mask and pixel-density, it probably fixes this issue on the first render, working nicely as it does on Android.

I will it later try without my fix and with this new svg version.

If it fixes this issue, I think I will leave my fix anyway as it's simpler and certainly improves the paintInside performance and memory usage on 2nd render and beyond.