Comments (5)
Hi, @illrill I'm basically keeping a simplified schema without the patch version for no particular reason. I generally bump the minor as I intentionally avoid breaking changes (e.g. I did introduce a different configuration format a while back, but ensured that the action would still support old files). If I do one, I would indeed bump the major.
In any case, I'm fine with using a full semver string if that makes things clearer downstream. I will republish the latest version as 1.4.0 and follow from there.
Thanks!
from labeler.
Thanks for the feedback!
Actually the main concern I had was around what would happen after 1.9 - I just assumed it would automatically hit 2.0 even if there's no major/breaking change. But perhaps I assumed too much, now that you explained it... It would become 1.11, wouldn't it? If that's the case, it's fine as-is for me.
The background to why I care is that the administrators of our Github Enterprise organization has a rule that they need to approve and "whitelist" each major version of all open-source actions. So when we reach version 2.0, I'll need to go through the hoops of requesting the admins to re-whitelist srvaora/labeler@2.*
😄
from labeler.
BTW, the organization I consult for is H&M Group, so this piece of software is used by a quite large company 🥇 💪
from labeler.
Yeah, I think you summarize the point quite well. I originally didn't want to overcomplicate the versioning part but at the point this is used by orgs with minimum supply chain controls standards will actually save time.
I expect we'll stay on 1.x for a fair amount of time.
Thanks a lot for the feedback and happy to see this is useful to you at H&M!
from labeler.
Closing but let me know if I there are any loose threads there!
from labeler.
Related Issues (20)
- `appendOnly: true` doesn't seem to work HOT 4
- ~~What flavour of regex is being used ?~~ README: add info about using escape character in regexes HOT 3
- `fail_on_error: true` doesn't seem to work HOT 4
- Could a "moving" `v1` tag be added to this repo ? HOT 2
- 1.8.0 release failed HOT 2
- Enhanced label customization HOT 2
- author-can-merge: false does not seem to work HOT 13
- [Feature] Label only if unlabled
- [Feature] Apply labels based on author's team membership HOT 1
- feat: calculate age based on modification date HOT 1
- feat: add a more comprehensive labeler example for self-use and demonstration HOT 2
- Add support for issues HOT 5
- [Feature] Naming labels based on regex capture groups HOT 1
- Ignore files in PR Size condition HOT 3
- [Feature] support local config file HOT 2
- Cannot run the action since 1.6.2 release: action.tar.gz not found HOT 4
- [Labeler] job no more working -- Docker build failed with exit code 1 HOT 2
- Avoid referencing `latest` in Dockerfile HOT 2
- label based on name of PR target branch HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from labeler.