Giter Site home page Giter Site logo

Comments (5)

ssseasonnn avatar ssseasonnn commented on May 2, 2024

@caixingke 😊谢谢提醒,是我没考虑周到,明天修复么么哒

from rxdownload.

caixingke avatar caixingke commented on May 2, 2024

对了, 代码中这么处理:

try {
    try {
         ...
    } finally {
        Utils.close(record);
        Utils.close(recordChannel);
        Utils.close(save);
        Utils.close(saveChannel);
        Utils.close(inStream);
        Utils.close(response);
    }
} catch (IOException e) {
    Log.i(TAG, Thread.currentThread().getName() + " download failed or cancel!");
    emitter.onError(e);
}

比如, 在 record 流关闭失败时, 是不是会导致 save / inStream / response 等流没有进行关闭?
所以建议流的关闭还是这样子进行:

try {

} catch (IOException e) {
    ...
} finally {
    try {
        Utils.close(record);
    } catch (IOException e) {

    }
    一个流一个流进行关闭
} 

from rxdownload.

caixingke avatar caixingke commented on May 2, 2024

还有一个, FileHelper.createDirectories中的 file.mkdir()是否需要改为file.mkdirs()?

from rxdownload.

ssseasonnn avatar ssseasonnn commented on May 2, 2024

@caixingke 哈哈, 谢谢大神指点.

from rxdownload.

ssseasonnn avatar ssseasonnn commented on May 2, 2024

@caixingke 新版本已经修复了这几个问题, 谢谢大神

from rxdownload.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.