Comments (7)
Hmm I would prefer a more api centric approach
from phpstan-todo-by.
issue/pr closed state handling was implemented with #62
as you pointed out the 'released' state is not easily to determine. until github.com provides a proper mean to detect this state I will close this issue for now.
thanks for the feedback though
from phpstan-todo-by.
We could implement a todo-by-ticket github-issues fetcher todo that.
This should work for github issues and PRs - these are very similar on github
Just enhance the rule implemented with #26 with a new fetcher
Since github issue identifiers have a different pattern then jira issue keys, we might need a separate rule
from phpstan-todo-by.
sadly, what I was thinking seems to be not doable easily: the information of the first git tag which includes the PR, which you can view in GitHub interface, is not exposed in the API.
I can't find any easy way to guess this information.
The best which can be done is to expire todo comment if the issue is resolved or the PR is merged, but IMO it's less useful than the logic based on versions
from phpstan-todo-by.
the refined-github browser extensions renders a note in PRs which have been merged and are part of a PR:
you might find some inspiration there
from phpstan-todo-by.
haha I didn't even know this information was added by this addon, I use it since too much time 😅
they look into this url and hack into the html
https://github.com/staabm/phpstan-todo-by/branch_commits/98d37d9dcfbcf1a70bb7a36ecea7c6ca7430c347
it seems there is no API equivalent. This solution is a bit hacky: I think there is no BC policy on this type of html url. That why from time to time the add-on has bugs: when GH changes its urls / or html markdown.
But if you're still okay.... why not ;)
from phpstan-todo-by.
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
from phpstan-todo-by.
Related Issues (20)
- Set level by env HOT 3
- Regression: 0.1.7 crashes when current Git project has no tags, even if no todo comments reference a version HOT 6
- multi git repo setup HOT 1
- expire comment by composer package version HOT 4
- Expire comment by config value HOT 6
- TodoByPackageVersionRule: backtrack limit error HOT 5
- Idea: Support Symfony's deprecation-contracts HOT 18
- BC Break: re-organize config file
- by a semantic version constraint matched against a Composer dependency not working HOT 8
- Improve Expiration Date recognition HOT 2
- TodoByVersionRule should not match date comments HOT 1
- Issue caused by a single-line block format comment is printed incorrectly HOT 1
- http caching HOT 4
- Reduce http requests HOT 1
- DX: ticket-rule: add "see $url" tip HOT 2
- DX: Define error identifiers HOT 4
- Respect configurable vendor folder location HOT 5
- Get an error for a TODO without an expiration constraint HOT 1
- support full github issue urls HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phpstan-todo-by.