Giter Site home page Giter Site logo

Comments (3)

cliedeman avatar cliedeman commented on August 16, 2024

getRenderedComponent can probably be safely be removed. It was originally copied from here: https://github.com/erikras/redux-form-material-ui/blob/master/src/createComponent.js.

On reasons to keep createComponent: I should probably allow passing through a fieldRef using the modern React.createRef() method for people who want access to the inner object.

from formik-mui.

cherniavskii avatar cherniavskii commented on August 16, 2024

IMHO it's better get rid of createComponent for now - props mapping logic is present in each component separately anyway. The only thing createComponent is doing now - setting displayName, but IMHO it should be done in every component separately.

I should probably allow passing through a fieldRef

There's no need to handle any refs manually if we'll get rid of createComponent. This way all components will be functional (right now they are classes, that's why problem with refs may exist).

I can submit a PR ;)

from formik-mui.

cliedeman avatar cliedeman commented on August 16, 2024

Please go ahead. I think the simplified code will be easier to follow and customize.

from formik-mui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.